[HOLD for payment 2023-12-29] [$500] IOU - Error message in Amount page overlaps with amount field when zoom level in 150%

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.9-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32460

Action Performed:

1. Go to staging.new.expensify.com on mweb Safari
2. Go to any chat > + > Request money
3. Click Next without entering the amount
4. Increase the zoom level to 150%

Expected Result:

The error will not overlap with amount input field

Actual Result:

The error overlaps with amount input field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6304456_1701955194737.RPReplay_Final1701906464.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01485e3068c4913aa8
• Upwork Job ID: 1732799149677228032
• Last Price Increase: 2023-12-14
• Automatic offers:
• jjcoffee | Reviewer | 28062575
• FitseTLT | Contributor | 28062576

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[flodnv]

Welp, I found another bug on production:

Edit: reported here: https://expensify.slack.com/archives/C049HHMV9SM/p1701966565899779

[flodnv]

I was not able to reproduce on my Pixel 6 on Chrome. I'm going to say this is not a blocker

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01485e3068c4913aa8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message in Amount page overlaps with amount field when zoom level in 150%

What is the root cause of that problem?

This is because we are using absolute positioning for form error message to position it bottom of Amount text input (TextInputWithCurrencySymbol) here

App/src/pages/iou/steps/MoneyRequestAmountForm.js

Lines 291 to 292 in 5a0b7fd

	style={[styles.pAbsolute, styles.b0, styles.mb0, styles.ph5, styles.w100]}
	isError

Whenever there is enough space the error message will stick to the botom of the view that holds the amount text input but when we zoom in and view is pushed up to have a size that can't hold both amount text input and the error message the error message will overlap with the input as the error message is absolutely positioned to the bottom of the parent view component as indicated in the above code.
This change of code was introduced in this pr to fix the amount input getting displaced when there is an error message but we shouldn't use absolute positioning as absolute positioned components doesn't occupy space in the dom and it will overlap on the amount input whenever there is no enough space

What changes do you think we should make in order to solve the problem?

To deal with both issues we should remove absolute positioning and put form help message in a parent view that will have a fixed height (enough to hold the form error message) and hold that space whether there is error message or not and the amount input displacing problem will be fixed without creating this issue of overlapping on zoom.

What alternative solutions did you explore? (Optional)

But if we want to keep the amount input centered we can keep the error message positioned absolute (leaving the current implementation) and set min-height to the parent view that holds both the amount input and the error message.
or give padding or margin to the amount input or the parent view to reserve a space the error message will be displayed without overlapping on the amount input accordingly.

[melvin-bot]

@flodnv, @jjcoffee Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jjcoffee]

Unsure what the expected result would be here as there's nowhere to display the error message once you're zoomed that far in 😄 @FitseTLT Are you able to post a screenshot of your proposal's result?

[FitseTLT]

Unsure what the expected result would be here as there's nowhere to display the error message once you're zoomed that far in 😄 @FitseTLT Are you able to post a screenshot of your proposal's result?

Here is a demo @jjcoffee

demo.mp4

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[flodnv]

@FitseTLT when can we expect your PR? 🙏

[FitseTLT]

PR ready

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix error message overlap on zoom #33233

If no regressions arise, payment will be issued on 2023-12-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Reviewer)
• @FitseTLT requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Summarizing payouts for this issue:

Contributor: @FitseTLT $500 (paid via Upwork)
Contributor+: @jjcoffee $500 (payable via Upwork BZ checklist is completed)

@jjcoffee could you please complete the BZ checklist so that I can issue your payment?

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: fix error message positioning on amount page #30287
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30287/files#r1439298027
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - hard one to catch
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to any chat > + > Request money
2. Click Next without entering the amount
3. Increase the zoom level to 150%
4. Verify that the error message doesn't overlap with amount input

Do we agree 👍 or 👎

[jjcoffee]

@sakluger Checklist complete, sorry for the delay!

[sakluger]

Thanks! I created the regression test issue and completed all payouts.