Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU- App crashes on deleting distance request #32716

Closed
2 of 6 tasks
lanitochka17 opened this issue Dec 8, 2023 · 17 comments
Closed
2 of 6 tasks

[$500] IOU- App crashes on deleting distance request #32716

lanitochka17 opened this issue Dec 8, 2023 · 17 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.10-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch app
  2. Tap fab
  3. Tap Request money ---- Distance
  4. Enter start and finish waypoints
    5.Tap next
    6.Tap request
    7.Tap on distance request created to open distance request details page
    8.Tap 3 dots on top and select delete request and confirm delete

Expected Result:

When user taps on delete request, the created distance request must be deleted and app must not crash

Actual Result:

In distance request, when user taps on delete request app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6305625_1702039435439.3cras_1_.mp4

logs.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011b000b1269fb4693
  • Upwork Job ID: 1737236433193459712
  • Last Price Increase: 2023-12-19
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 8, 2023

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@danieldoglas
Copy link
Contributor

I'm stuck trying to run this on my iOS device locally, for some reason the app is not receiving any answers from Expensify

@danieldoglas
Copy link
Contributor

Ok, I was able to run main on my iOS simulator, but I can't even see the screen to create a distance request
image

@yuwenmemon
Copy link
Contributor

Able to reproduce on staging in iOS

@yuwenmemon
Copy link
Contributor

Can't reproduce on dev anymore. This was after merging #32746 to get the distance flow to work again, but I'm not sure if it's related or not.

@yuwenmemon
Copy link
Contributor

Plus it's not like I can test a version before cause the app was crashing then 😅. So I'm going to remove the blocker and close since this seems to have been resolved.

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Dec 8, 2023
@danieldoglas danieldoglas reopened this Dec 19, 2023
@danieldoglas danieldoglas added Daily KSv2 and removed Hourly KSv2 labels Dec 19, 2023
@danieldoglas danieldoglas added Hourly KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed Daily KSv2 labels Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@danieldoglas danieldoglas added Daily KSv2 and removed Hourly KSv2 labels Dec 19, 2023
@danieldoglas
Copy link
Contributor

@joekaufmanexpensify this was already finished and deployed, I'm reopening the issue so we can track payment for @situchan

@joekaufmanexpensify
Copy link
Contributor

Adding external label to create upwork job.

@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Dec 19, 2023
@melvin-bot melvin-bot bot changed the title IOU- App crashes on deleting distance request [$500] IOU- App crashes on deleting distance request Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~011b000b1269fb4693

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@joekaufmanexpensify joekaufmanexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 19, 2023
@joekaufmanexpensify
Copy link
Contributor

@situchan offer sent for $500!

@joekaufmanexpensify
Copy link
Contributor

$500 sent to @situchan and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

5 participants