Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme Switching] Status - The status tab doesn't change the theme in Light mode #33087

Closed
6 tasks done
lanitochka17 opened this issue Dec 14, 2023 · 4 comments
Closed
6 tasks done
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 14, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - internal Team
Slack conversation:

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Go to Settings -> Preferences -> Theme -> Light
  4. Then go to Settings -> Profile -> Status
  5. Notice that tab doesn't change the theme in Light mode

Expected Result:

The status tab change the theme in Light mode

Actual Result:

The status tab doesn't change the theme in Light mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

![Bug6313338_1702573564797!image__196_](https://github.com/Expensify/App/assets/78819774/15e13173-e5b9-4e6f-96d9-6ca58d284542)

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Dec 14, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 14, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 14, 2023

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@situchan
Copy link
Contributor

situchan commented Dec 14, 2023

Asked here

@grgia
Copy link
Contributor

grgia commented Dec 14, 2023

Closing as dupe. PR is already up

@grgia grgia closed this as completed Dec 14, 2023
@grgia grgia changed the title Status - The status tab doesn't change the theme in Light mode [Theme Switching] Status - The status tab doesn't change the theme in Light mode Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants