Status - Inappropriate error message when setting custom time in the past

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.13-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Settings > Profile > Status
3. Click Clear after
4. Click Custom > Time
5. Enter a time in the past
6. Save it

Expected Result:

The error message shows "Please choose a time in the future"

Actual Result:

The error message shows "Please choose a time at least one minute ahead." when it should have been "Please choose a time in the future" because the current error message will still result in failure when choosing time one minute ahead

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313921_1702605618619.bandicam_2023-12-15_09-45-30-081.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

I see nothing wrong with this error message "Please choose a time at least one minute ahead" means to choose a time one minute ahead of the current time, not the time inputted in the form.

We could make it clearer by updating the error message to say "Please choose a time at least one minute in the future".

Regardless, there's no need to block deploy on this, or fix this, since this is the expected behavior.