[HOLD for payment 2024-01-02] [HOLD for payment 2023-12-29] [$500] Contact method - Delete contact method confirmation pop-up appears after slight delay #33410

lanitochka17 · 2023-12-21T13:04:58Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.4.15-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - internal Team
Slack conversation:

Issue found when executing PR #32901

Action Performed:

Go to Settings > Profile > Contact method
Click New contact method
Enter a new email
Click on the newly added email
Click Remove

Expected Result:

Delete confirmation pop-up appears without delay

Actual Result:

Delete confirmation pop-up appears after slight delay.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6322617_1703162575019.bandicam_2023-12-21_20-18-49-816.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016b88b71e8f06ec60
Upwork Job ID: 1737900809599180800
Last Price Increase: 2023-12-21
Automatic offers:

shubham1206agra | Reviewer | 28067079
FitseTLT | Contributor | 28067080

Issue Owner

Current Issue Owner: @isabelastisser

github-actions · 2023-12-21T13:05:14Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-12-21T13:05:18Z

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

FitseTLT · 2023-12-21T13:08:55Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete contact method confirmation pop-up appears after slight delay

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Lines 222 to 227 in 2f7c2b2

    
           toggleDeleteModal(isOpen) { 
        
               InteractionManager.runAfterInteractions(() => { 
        
                   this.setState({isDeleteModalOpen: isOpen}); 
        
               }); 
        
               Keyboard.dismiss(); 
        
           }

What is the root cause of that problem?

It is caused by this pr to display modal after keyboard is dismissed

What changes do you think we should make in order to solve the problem?

We should do that only for touch screen

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Lines 222 to 227 in 2f7c2b2

    
           toggleDeleteModal(isOpen) { 
        
               InteractionManager.runAfterInteractions(() => { 
        
                   this.setState({isDeleteModalOpen: isOpen}); 
        
               }); 
        
               Keyboard.dismiss(); 
        
           }

change it to

toggleDeleteModal(isOpen) {
        if (canUseTouchScreen()) {
            InteractionManager.runAfterInteractions(() => {
                this.setState({isDeleteModalOpen: isOpen});
            });
            Keyboard.dismiss();
        } else {
            this.setState({isDeleteModalOpen: isOpen});
        }
    }

What alternative solutions did you explore? (Optional)

allroundexperts · 2023-12-21T13:12:00Z

Hm... Is this a bug? We decided to run it after all interactions.

NikkiWines · 2023-12-21T16:54:45Z

This seems to only occur when the contact method is unvalidated, which makes sense given @allroundexperts's and @FitseTLT's comments above. I do think it comes across a bit buggy and we should fix it. Especially if we're applying logic that only impacts touchscreen devices to all platforms

NikkiWines · 2023-12-21T18:20:04Z

Anyway, @FitseTLT your solution looks good to me! Adding the relevant labels and assigning you 👍

melvin-bot · 2023-12-21T18:20:14Z

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-12-21T18:20:18Z

Job added to Upwork: https://www.upwork.com/jobs/~016b88b71e8f06ec60

melvin-bot · 2023-12-21T18:20:23Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

melvin-bot · 2023-12-21T18:20:39Z

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-12-21T18:20:43Z

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

shubham1206agra · 2023-12-21T18:36:36Z

@FitseTLT can you raise a PR quickly?
So I can also start recording the videos also

FitseTLT · 2023-12-21T18:40:08Z

K 👍

situchan · 2023-12-21T18:43:57Z

I think this should be handled as regression.

The correct flow would be:

original contributor raise PR
original C+ review PR
new contributor get partial bounty for their solution being used

cc: @mallenexpensify (as we were discussing this process recently)

shubham1206agra · 2023-12-21T18:49:32Z

@situchan above flow only applies only when the original author raised the PR without another proposal getting selected, and uses the solution from the proposal here

melvin-bot · 2023-12-22T05:16:12Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-12-22T05:16:16Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix delay of contact delete modal opening #33439

If no regressions arise, payment will be issued on 2023-12-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@FitseTLT requires payment automatic offer (Contributor)
@shubham1206agra requires payment automatic offer (Reviewer)

melvin-bot · 2023-12-22T05:16:17Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@shubham1206agra] Determine if we should create a regression test for this bug.
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-12-26T00:06:59Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix delay of contact delete modal opening #33439

If no regressions arise, payment will be issued on 2024-01-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@FitseTLT requires payment automatic offer (Contributor)
@shubham1206agra requires payment automatic offer (Reviewer)

melvin-bot · 2023-12-26T00:07:00Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@shubham1206agra] Determine if we should create a regression test for this bug.
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2024-01-02T17:06:04Z

Issue is ready for payment but no BZ is assigned. @puneetlath you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

puneetlath · 2024-01-02T17:07:31Z

Hm, @isabelastisser is already assigned. Not sure why it added me, but going to remove myself.

shubham1206agra · 2024-01-03T15:46:45Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Display modal after keyboard is hidden #32901
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/32901/files#r1440603557
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
[@shubham1206agra] Determine if we should create a regression test for this bug. No as this was deploy blocker
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

isabelastisser · 2024-01-03T21:31:22Z

Hey @shubham1206agra, please accept the offer in Upwork and I will process the payment. Thanks!

shubham1206agra · 2024-01-04T04:44:58Z

@isabelastisser Accepted

isabelastisser · 2024-01-05T14:47:28Z

The payment was made in Upwork. All set!

mallenexpensify · 2024-01-09T00:33:40Z

@isabelastisser can you please post the amounts that were paid, to whom and their roles? I have this set at a TextExpander that I fill out each time.

Contributor: @ paid $ via Upwork
Contributor+: @

isabelastisser · 2024-01-09T19:23:50Z

@mallenexpensify

Contributor: @FitseTLT paid $500 via Upwork
Contributor+: @shubham1206agra paid $500 via Upwork

lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 21, 2023

github-actions bot added Engineering Hourly KSv2 labels Dec 21, 2023

melvin-bot bot assigned NikkiWines Dec 21, 2023

github-actions bot mentioned this issue Dec 21, 2023

Deploy Checklist: New Expensify 2023-12-21 #33391

Closed

51 tasks

melvin-bot bot mentioned this issue Dec 21, 2023

[HOLD for payment 2023-12-29] [$500] mWeb/Chrome-Contact methods-Confirmation window moves when trying to remove secondary contact method #32262

Closed

6 tasks

NikkiWines added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 21, 2023

melvin-bot bot assigned isabelastisser Dec 21, 2023

NikkiWines added the External Added to denote the issue can be worked on by a contributor label Dec 21, 2023

This comment was marked as outdated.

Sign in to view

melvin-bot bot changed the title ~~Contact method - Delete contact method confirmation pop-up appears after slight delay~~ [$500] Contact method - Delete contact method confirmation pop-up appears after slight delay Dec 21, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 21, 2023

melvin-bot bot assigned shubham1206agra Dec 21, 2023

NikkiWines assigned FitseTLT Dec 21, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 21, 2023

melvin-bot bot changed the title ~~[$500] Contact method - Delete contact method confirmation pop-up appears after slight delay~~ [HOLD for payment 2023-12-29] [$500] Contact method - Delete contact method confirmation pop-up appears after slight delay Dec 22, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Dec 22, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 26, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 28, 2023

melvin-bot bot assigned puneetlath Jan 2, 2024

melvin-bot bot removed the Overdue label Jan 2, 2024

puneetlath removed their assignment Jan 2, 2024

shubham1206agra mentioned this issue Jan 3, 2024

Display modal after keyboard is hidden #32901

Merged

47 tasks

isabelastisser closed this as completed Jan 3, 2024

mallenexpensify reopened this Jan 5, 2024

isabelastisser closed this as completed Jan 5, 2024

mallenexpensify reopened this Jan 9, 2024

isabelastisser closed this as completed Jan 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-01-02] [HOLD for payment 2023-12-29] [$500] Contact method - Delete contact method confirmation pop-up appears after slight delay #33410

[HOLD for payment 2024-01-02] [HOLD for payment 2023-12-29] [$500] Contact method - Delete contact method confirmation pop-up appears after slight delay #33410

lanitochka17 commented Dec 21, 2023 •

edited by puneetlath

Loading

github-actions bot commented Dec 21, 2023

melvin-bot bot commented Dec 21, 2023

FitseTLT commented Dec 21, 2023 •

edited

Loading

allroundexperts commented Dec 21, 2023

NikkiWines commented Dec 21, 2023 •

edited

Loading

NikkiWines commented Dec 21, 2023

melvin-bot bot commented Dec 21, 2023

This comment was marked as outdated.

melvin-bot bot commented Dec 21, 2023

melvin-bot bot commented Dec 21, 2023

melvin-bot bot commented Dec 21, 2023

melvin-bot bot commented Dec 21, 2023

shubham1206agra commented Dec 21, 2023

FitseTLT commented Dec 21, 2023

situchan commented Dec 21, 2023 •

edited

Loading

shubham1206agra commented Dec 21, 2023

melvin-bot bot commented Dec 22, 2023

melvin-bot bot commented Dec 22, 2023

melvin-bot bot commented Dec 22, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Jan 2, 2024

puneetlath commented Jan 2, 2024

shubham1206agra commented Jan 3, 2024 •

edited by isabelastisser

Loading

isabelastisser commented Jan 3, 2024

shubham1206agra commented Jan 4, 2024

isabelastisser commented Jan 5, 2024

mallenexpensify commented Jan 9, 2024

isabelastisser commented Jan 9, 2024

[HOLD for payment 2024-01-02] [HOLD for payment 2023-12-29] [$500] Contact method - Delete contact method confirmation pop-up appears after slight delay #33410

[HOLD for payment 2024-01-02] [HOLD for payment 2023-12-29] [$500] Contact method - Delete contact method confirmation pop-up appears after slight delay #33410

Comments

lanitochka17 commented Dec 21, 2023 • edited by puneetlath Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

github-actions bot commented Dec 21, 2023

melvin-bot bot commented Dec 21, 2023

FitseTLT commented Dec 21, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

allroundexperts commented Dec 21, 2023

NikkiWines commented Dec 21, 2023 • edited Loading

NikkiWines commented Dec 21, 2023

melvin-bot bot commented Dec 21, 2023

This comment was marked as outdated.

melvin-bot bot commented Dec 21, 2023

melvin-bot bot commented Dec 21, 2023

melvin-bot bot commented Dec 21, 2023

melvin-bot bot commented Dec 21, 2023

shubham1206agra commented Dec 21, 2023

FitseTLT commented Dec 21, 2023

situchan commented Dec 21, 2023 • edited Loading

shubham1206agra commented Dec 21, 2023

melvin-bot bot commented Dec 22, 2023

melvin-bot bot commented Dec 22, 2023

melvin-bot bot commented Dec 22, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Dec 26, 2023

melvin-bot bot commented Jan 2, 2024

puneetlath commented Jan 2, 2024

shubham1206agra commented Jan 3, 2024 • edited by isabelastisser Loading

isabelastisser commented Jan 3, 2024

shubham1206agra commented Jan 4, 2024

isabelastisser commented Jan 5, 2024

mallenexpensify commented Jan 9, 2024

isabelastisser commented Jan 9, 2024

lanitochka17 commented Dec 21, 2023 •

edited by puneetlath

Loading

FitseTLT commented Dec 21, 2023 •

edited

Loading

NikkiWines commented Dec 21, 2023 •

edited

Loading

situchan commented Dec 21, 2023 •

edited

Loading

shubham1206agra commented Jan 3, 2024 •

edited by isabelastisser

Loading