Expense - Expense preview with more than 1 request grays out when requesting money offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to workspace chat that has some requests
2. Go offline
3. Create a money request

Expected Result:

The expense preview in the workspace chat will not gray out

Actual Result:

The expense preview in the workspace chat grays out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6332714_1704419197805.20240105_064703.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expense preview in the workspace chat grays out

What is the root cause of that problem?

When adding a new request, we will update iouReport.pendingFields.preview: UPDATE

App/src/components/ReportActionItem/ReportPreview.js

Line 264 in 2d455bf

<OfflineWithFeedback pendingAction={lodashGet(props, 'iouReport.pendingFields.preview')}>

We are using iouReport.pendingFields.preview` field for ReportPreview. So that when there is a new request money, the Report Preview will be greyed out

What changes do you think we should make in order to solve the problem?

App/src/components/ReportActionItem/ReportPreview.js

Line 264 in 2d455bf

<OfflineWithFeedback pendingAction={lodashGet(props, 'iouReport.pendingFields.preview')}>

In here we should use iouReport.pendingFields.createChat instead of iouReport.pendingFields.preview

What alternative solutions did you explore? (Optional)

[DylanDylann]

@marcaaron This issue was caused by this PR. I am available to raise a quick PR if you agree with my proposal above

[c3024]

Greying out when offline is the expected behaviour as per the discussion here. I don't think this is a regression.