Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Android – Settings - App flickering when enter an authenticator code in 2FA creation page #34140

Closed
1 of 6 tasks
kbecciv opened this issue Jan 9, 2024 · 18 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Jan 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.23-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Tap on Settings/ Security/ Two-factor authentication
  4. Tap on Copy and Next
  5. Then enter any six digits in a code field.

Expected Result:

App is not flickering when enter an authenticator code in 2FA creation page

Actual Result:

App flickering when enter an authenticator code in 2FA creation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6336711_1704807878592.App_flickering_when_enter_an_authenticator_code_in_2FA_creation_page.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0178f42913610b69a7
  • Upwork Job ID: 1767217663958515712
  • Last Price Increase: 2024-03-11
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@situchan
Copy link
Contributor

situchan commented Jan 9, 2024

I am not able to reproduce on main. Tested on both android phone and emulator

@amyevans
Copy link
Contributor

Thanks @situchan!

This doesn't need to block deploy. We can retest with the next release just to ensure it's fixed.

@amyevans amyevans added Daily KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 10, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 12, 2024
Copy link

melvin-bot bot commented Jan 15, 2024

@amyevans Eep! 4 days overdue now. Issues have feelings too...

@amyevans
Copy link
Contributor

Verified it's no longer reproducible:

screen-20240115-124311.mp4

Closing this out!

@melvin-bot melvin-bot bot removed the Overdue label Jan 15, 2024
@lanitochka17
Copy link

Issue is still reproducible on the latest build 1.4.48-0
Repro on Pixel (stg and prod), not repro on Samsung

video_2024-03-06_18-28-43.mp4

@lanitochka17 lanitochka17 reopened this Mar 6, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2024
@amyevans
Copy link
Contributor

amyevans commented Mar 8, 2024

Hmm I just retested on a Pixel 3a and am still unable to repro. I'll assign BZ to attempt to repro/take triage from here.

@melvin-bot melvin-bot bot removed the Overdue label Mar 8, 2024
@amyevans amyevans added the Bug Something is broken. Auto assigns a BugZero manager. label Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
@sonialiap
Copy link
Contributor

sonialiap commented Mar 11, 2024

I do not see any flickering. Here is my test (pixel 3 and pixel 7):

screen-20240311-130756.mp4
screen-20240311-131517.mp4

@melvin-bot melvin-bot bot removed the Overdue label Mar 11, 2024
@sonialiap
Copy link
Contributor

@lanitochka17 @kbecciv I cannot reproduce the flickering but I noticed that in both videos where it is reproducible, there's an auto-fill suggestion which neither Amy nor I have. I'm not sure how to reproduce this. Do you guys know where that suggestion is coming from? Katya I see yours says autofill but I can't quite see from where, maybe "з почты"? Sveta, your video shows "from messages". So both of your apps are trying to auto-fill from SMS messages? Did you recently receive a code by SMS that might be affecting the test?

I tried logging into an app that sends me a SMS code and didn't read it. Then tried the test and I did not get the "auto fill from messages". Not sure how to repo the behavior you're seeing.

image image

My test, no auto-fill suggstion

image

@amyevans
Copy link
Contributor

@amyevans
Copy link
Contributor

From the thread -

Galaxy S10 / android 11, I do have the autofill suggestion but flickering happens once only.

az_recorder_20240311_113450.1.mp4

But for the tester reported has Mi11 Lite / Android 13 it flickers when entering each digit.

Screenrecorder-2024-03-11-17-31-43-510.mp4

@amyevans
Copy link
Contributor

I guess we can go external with it and see if we get any traction, but if not I could also see us closing after a week or two.

@amyevans amyevans added the External Added to denote the issue can be worked on by a contributor label Mar 11, 2024
Copy link

melvin-bot bot commented Mar 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0178f42913610b69a7

@melvin-bot melvin-bot bot changed the title Android – Settings - App flickering when enter an authenticator code in 2FA creation page [$500] Android – Settings - App flickering when enter an authenticator code in 2FA creation page Mar 11, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 11, 2024
Copy link

melvin-bot bot commented Mar 11, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2024
@amyevans
Copy link
Contributor

Awaiting proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 13, 2024
@amyevans
Copy link
Contributor

Alright it's been a week and we don't have any proposals, it's also not assigned to a wave or VIP so not a priority. I'm going to close, but feel free to reopen if you disagree @sonialiap!

@melvin-bot melvin-bot bot removed the Overdue label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants