Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Web - Workspace - Public room can't be opened for the second time #34165

Closed
1 of 6 tasks
kbecciv opened this issue Jan 9, 2024 · 28 comments
Closed
1 of 6 tasks
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@kbecciv
Copy link

kbecciv commented Jan 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.23.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Log in with an expensifail account
  2. Create a new workspace
  3. Create a public room
  4. Write any text in the room
  5. Copy the link address
  6. Open it in an incognito window
  7. Close the incognito window
  8. Open the link in an incognito window again

Expected Result:

I should be able to open the room.

Actual Result:

Public room can't be opened for the second time.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6336811_1704814572676.bandicam_2024-01-09_11-15-33-888.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0183f8c3cb1bf184ce
  • Upwork Job ID: 1745032606935470080
  • Last Price Increase: 2024-02-14
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@thienlnam
Copy link
Contributor

thienlnam commented Jan 10, 2024

This might be a BE issue - I can reproduce on both staging and production. Removing the blocker since it's reproducible for both environments.

I can't even open the public room the first time

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 10, 2024
@Beamanator
Copy link
Contributor

Beamanator commented Jan 10, 2024

Hmm I can def open the public room the first time, sometimes even the 2nd time, but it's very slow to open...

  • There seems to be a LOT of OpenApp stuff returned that I wouldn't really expect:
    • currencyList - not sure if that's necessary for anonymous public rooms
    • report_2628257014907189, even though I'm opening the public room 6685953273940764
      • chatType is domainAll, so maybe
    • report_4212696368636102 - maybe this is the concierge chat? Why do we have this? haha
    • report_6685953273940764 - ok ya this is the public room i'm opening
    • user has validated: true & isSubscribedToNewsletter which I feel should both be false, right?
    • personalDetailsList of pretty much everyone on a domain (expensifail)

@Beamanator
Copy link
Contributor

https://staging.new.expensify.com/r/6685953273940764

  • Could join every time (though sometimes it took a while to load)

https://staging.new.expensify.com/r/5540700703264571

  • same

@Beamanator
Copy link
Contributor

Hmm I did see this once, where I wasn't able to load the report 🤔

Screenshot 2024-01-10 at 12 33 35 PM

@Beamanator
Copy link
Contributor

Looks like potentially a Google OAuth thing, I think if it doesn't load properly we somehow skip loading OpenReport and go straight back to the main login page. I'm going to open this up externally b/c it LOOKS like it's not a backend problem actually

@Beamanator Beamanator added the External Added to denote the issue can be worked on by a contributor label Jan 10, 2024
@melvin-bot melvin-bot bot changed the title Web - Workspace - Public room can't be opened for the second time [$500] Web - Workspace - Public room can't be opened for the second time Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0183f8c3cb1bf184ce

@Beamanator Beamanator added the Needs Reproduction Reproducible steps needed label Jan 10, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@Beamanator
Copy link
Contributor

Also adding Needs Reproduction b/c I can't consistently reproduce - if I could, I would have inspected the failed network requests from my comment above 😅

@melvin-bot melvin-bot bot added the Overdue label Jan 12, 2024
Copy link

melvin-bot bot commented Jan 15, 2024

@Beamanator, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

@Beamanator
Copy link
Contributor

same

@melvin-bot melvin-bot bot removed the Overdue label Jan 16, 2024
Copy link

melvin-bot bot commented Jan 17, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 18, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

@Beamanator, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Jan 24, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jan 29, 2024

@Beamanator, @allroundexperts 12 days overdue now... This issue's end is nigh!

@allroundexperts
Copy link
Contributor

allroundexperts commented Jan 29, 2024

Still not reproducible.

@melvin-bot melvin-bot bot removed the Overdue label Jan 29, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Jan 31, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Feb 1, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

@Beamanator, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Beamanator
Copy link
Contributor

Not overdue, waiting for more tests but probably can close this

@melvin-bot melvin-bot bot removed the Overdue label Feb 5, 2024
@Beamanator Beamanator added Reviewing Has a PR in review retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause and removed Reviewing Has a PR in review labels Feb 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Feb 8, 2024

@Beamanator, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Feb 12, 2024

@Beamanator, @allroundexperts Still overdue 6 days?! Let's take care of this!

@Beamanator
Copy link
Contributor

Keeping open for applause to hopefully test again

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@Beamanator
Copy link
Contributor

Closing since we haven't been able to reproduce in a while

@melvin-bot melvin-bot bot removed the Overdue label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
None yet
Development

No branches or pull requests

5 participants