Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-18] LHN - Tooltip Appears After FAB Opens and Displays the List When Hovering Over the FAB Icon #34183

Closed
1 of 6 tasks
lanitochka17 opened this issue Jan 9, 2024 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.23-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1, Sign in to the staging environment of Expensify
2, Click on the Floating Action Button (FAB)
3, Hover over the FAB again; the tooltip continues to be displayed

Expected Result:

The tooltip should not appear after the modal opens

Actual Result:

Even after the modal opens, the tooltip persists when hovering over the FAB

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337070_1704830296595.Screen1.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@dummy-1111
Copy link
Contributor

This is a regression of this PR #33247

@dummy-1111
Copy link
Contributor

dummy-1111 commented Jan 9, 2024

Both #34185 and this issue are related to the TS migration PR #33247

Simply applying forwardRef would solve both issues

Copy link

melvin-bot bot commented Jan 9, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@roryabraham
Copy link
Contributor

Fix is being CP'd to staging, cheers to @situchan for the quick fix

@thienlnam thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Jan 10, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 Hourly KSv2 labels Jan 10, 2024
@melvin-bot melvin-bot bot changed the title LHN - Tooltip Appears After FAB Opens and Displays the List When Hovering Over the FAB Icon [HOLD for payment 2024-01-17] LHN - Tooltip Appears After FAB Opens and Displays the List When Hovering Over the FAB Icon Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-17. 🎊

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jan 11, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Jan 11, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-17] LHN - Tooltip Appears After FAB Opens and Displays the List When Hovering Over the FAB Icon [HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] LHN - Tooltip Appears After FAB Opens and Displays the List When Hovering Over the FAB Icon Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-18. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 16, 2024
Copy link

melvin-bot bot commented Jan 18, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added the Overdue label Jan 18, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

@roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

@roryabraham roryabraham added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 19, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot removed the Overdue label Jan 19, 2024
@roryabraham
Copy link
Contributor

Whoops, looks like we just need to issue payment to @situchan for the PR (no C+)

@roryabraham roryabraham changed the title [HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] LHN - Tooltip Appears After FAB Opens and Displays the List When Hovering Over the FAB Icon [HOLD for payment 2024-01-18] LHN - Tooltip Appears After FAB Opens and Displays the List When Hovering Over the FAB Icon Jan 19, 2024
@roryabraham roryabraham added Bug Something is broken. Auto assigns a BugZero manager. and removed Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. labels Jan 19, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

Current assignee @adelekennedy is eligible for the Bug assigner, not assigning anyone new.

@roryabraham
Copy link
Contributor

roryabraham commented Jan 19, 2024

Damn, the Upwork job isn't getting auto-created. @adelekennedy can you please issue payment of $500 to @situchan then close this out? You might have to manually create the Upwork job

@roryabraham roryabraham added the Awaiting Payment Auto-added when associated PR is deployed to production label Jan 19, 2024
@adelekennedy
Copy link

Upwork is having some trouble but I think I was able to extend you a contract @situchan

@adelekennedy
Copy link

payment made!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants