Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previously stored search input is sent to the backend instead of the latest value entered by the user #34353

Closed
1 of 6 tasks
m-natarajan opened this issue Jan 11, 2024 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@m-natarajan
Copy link

m-natarajan commented Jan 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.24-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @youssef-lr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1704921995746249

Action Performed:

  1. click on "search" icon beside the avatar
  2. Type user 1
  3. Check the API

Expected Result:

Latest entered input should be sent to backend

Actual Result:

Previously stored result is sent to backend

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2653.mp4
Screen.Recording.2024-01-10.at.22.23.55.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0187544a07fd9a4b27
  • Upwork Job ID: 1745445129843707904
  • Last Price Increase: 2024-01-11
@m-natarajan m-natarajan added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0187544a07fd9a4b27

Copy link

melvin-bot bot commented Jan 11, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@m-natarajan m-natarajan added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@rushatgabhane
Copy link
Member

this can be external (if we want to)

@youssef-lr
Copy link
Contributor

I have a fix included in an ongoing draft PR but figured I ship this separately sooner.

@mallenexpensify
Copy link
Contributor

@rushatgabhane should be assigned as C+, even if we fix this internally..... right?

@youssef-lr
Copy link
Contributor

Actually the PR I was planning to fix this in is almost ready, so I'll include the fix in there instead of fixing this separately.

@rushatgabhane should I assign you for reviewing it? We're adding the possibility to return personalDetails from SearchForReports so we can display proper avatars/display names of any user we search for.

@melvin-bot melvin-bot bot added the Overdue label Jan 15, 2024
@mallenexpensify
Copy link
Contributor

Do you have a link to the PR @youssef-lr ? Thx

@melvin-bot melvin-bot bot removed the Overdue label Jan 15, 2024
@youssef-lr
Copy link
Contributor

#34400

@rushatgabhane
Copy link
Member

@youssef-lr yeah sure you can assign it to me

@mallenexpensify
Copy link
Contributor

Assigned @rushatgabhane

@youssef-lr
Copy link
Contributor

Backend PRs are still under review.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 23, 2024
@youssef-lr
Copy link
Contributor

remaining PRs still in the works.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 29, 2024
@youssef-lr
Copy link
Contributor

Same.

@melvin-bot melvin-bot bot removed the Overdue label Jan 31, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

@youssef-lr @mallenexpensify @rushatgabhane this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

Copy link

melvin-bot bot commented Feb 6, 2024

@youssef-lr, @mallenexpensify, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

@youssef-lr
Copy link
Contributor

Bumped the reviewer

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2024
@youssef-lr
Copy link
Contributor

Looks like this was fixed in this PR unintentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

4 participants