-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
previously stored search input is sent to the backend instead of the latest value entered by the user #34353
Comments
Job added to Upwork: https://www.upwork.com/jobs/~0187544a07fd9a4b27 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane ( |
Triggered auto assignment to @mallenexpensify ( |
this can be external (if we want to) |
I have a fix included in an ongoing draft PR but figured I ship this separately sooner. |
@rushatgabhane should be assigned as C+, even if we fix this internally..... right? |
Actually the PR I was planning to fix this in is almost ready, so I'll include the fix in there instead of fixing this separately. @rushatgabhane should I assign you for reviewing it? We're adding the possibility to return |
Do you have a link to the PR @youssef-lr ? Thx |
@youssef-lr yeah sure you can assign it to me |
Assigned @rushatgabhane |
Backend PRs are still under review. |
remaining PRs still in the works. |
Same. |
@youssef-lr @mallenexpensify @rushatgabhane this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks! |
@youssef-lr, @mallenexpensify, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too... |
Bumped the reviewer |
Looks like this was fixed in this PR unintentionally. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.24-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @youssef-lr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1704921995746249
Action Performed:
Expected Result:
Latest entered input should be sent to backend
Actual Result:
Previously stored result is sent to backend
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Recording.2653.mp4
Screen.Recording.2024-01-10.at.22.23.55.mov
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: