Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan - Duplicate "receipt scanning failed" messages when the scanning fails #34579

Closed
6 tasks done
kbecciv opened this issue Jan 16, 2024 · 7 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Jan 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.25-6
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to 1:1 DM.
  2. Create a scan request with a receipt that will fail the scanning.
  3. When the scanning fails, go to request details page.

Expected Result:

There will be only one "receipt scanning failed" message.

Actual Result:

There are two "receipt scanning failed" messages; one from Expensify, another one below the receipt preview.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6344302_1705413209157.bandicam_2024-01-16_21-52-24-511.mp4

image

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 16, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 16, 2024

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 16, 2024
@abzokhattab
Copy link
Contributor

which message of the two should be displayed?

@mountiny
Copy link
Contributor

this is not a deploy blocker, also touching the violations project cc @cead22 for visibility, added to wave6 project but not sure what to do now, the report action in the chat is correct so we might just want to update the copy of the receipt red warning

This is up for discussion first though

@iwiznia
Copy link
Contributor

iwiznia commented Jan 16, 2024

ok going to put this through the regular assignment flow then

@iwiznia iwiznia removed their assignment Jan 16, 2024
@iwiznia iwiznia added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 16, 2024
Copy link

melvin-bot bot commented Jan 16, 2024

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@cead22
Copy link
Contributor

cead22 commented Jan 16, 2024

There will be only one "receipt scanning failed" message.

I don't think we've agreed that this is the expected outcome, so we should bring this discussion to slack first. AFAICT this is working as currently designed, so closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
No open projects
Development

No branches or pull requests

6 participants