Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Violation with type 'notice' being shown: "Receipt required over" #34773

Closed
cead22 opened this issue Jan 19, 2024 · 3 comments
Closed

Violation with type 'notice' being shown: "Receipt required over" #34773

cead22 opened this issue Jan 19, 2024 · 3 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@cead22
Copy link
Contributor

cead22 commented Jan 19, 2024

  • getViolationsForField doesn't check the violation type like TransactionUtils.hasViolation, so we're rendering a violation with type notice
  • We should update this code to make sure it works with violations with type violation
image image

@cdanwards @trevor-coleman @lindboe please comment for assignment

@cead22 cead22 added Engineering Daily KSv2 Improvement Item broken or needs improvement. labels Jan 19, 2024
@cead22 cead22 self-assigned this Jan 19, 2024
@cdanwards
Copy link
Contributor

Commenting for assignment

Copy link

melvin-bot bot commented Feb 14, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 14, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants