[$500] Room - App crashes when tapping on room header after leaving the

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.33.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to a room.
2. Tap room header > Share code.
3. Copy the share code.
4. Leave the room.
5. Paste the share code in another chat.
6. Tap on the link.
7. Tap on the room header.

Expected Result:

App does not crash.

Actual Result:

App crashes when tapping on room header after leaving the

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360768_1706614840367.Screen_Recording_20240130_071712_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ed7138f88427989
• Upwork Job ID: 1752299126125584384
• Last Price Increase: 2024-01-30

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010ed7138f88427989

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when opening a header of a room with no members

What is the root cause of that problem?

The issue is in this check:

App/src/components/MenuItem.tsx

Lines 548 to 552 in 5d0931d

	{(subtitle ?? subtitle === 0) && (
	<View style={[styles.justifyContentCenter, styles.mr1]}>
	<Text style={[styles.textLabelSupporting, ...(combinedStyle as TextStyle[])]}>{subtitle}</Text>
	</View>
	)}

We make a check subtitle ?? subtitle === 0, which never reaches the subtitle === 0 part as 0?? is not nullish. As a result, we have a "0" displayed with no text wrapper, which causes the crash.

What changes do you think we should make in order to solve the problem?

We should change that check to:

!!subtitle || subtitle === 0

What alternative solutions did you explore? (Optional)

[dukenv0307]

I believe this is a dupe of #35358, same root cause

[zanyrenney]

closing for dupe, listed above! ^