Chat - To enter link name in multi line, tapping enter key changes link to text

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.39.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4293571
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap on a report
3. Paste a link and send the message
4. Long press and tap edit comment
5. Select link url name part and delete it
6. Enter a text in url name part and tap enter

Expected Result:

Deleting url name part, entering a text & tapping enter key to enter link name in multi line, must not change link to text.

Actual Result:

Deleting url name part, entering a text & tapping enter key to enter link name in multi line, changes link to text.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6372633_1707428012528.mweb_staging.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related #vip-vsb
CC @quinthar

[tgolen]

This looks like probably an issue from the live markdown feature.

[tgolen]

@Skalakid Could you help verify if this is a bug with live markdown or not?

[roryabraham]

According to GitHub newlines can be in the text part of a link:

valid link

another valid
link

[roryabraham]

Interestingly, newlines in links work ok, it's just if you remove the text part of an existing link and then insert a newline into what remains that this happens.

[Skalakid]

@tgolen Yes it is connected with live markdown parsing system, just looking into it

[robertKozik]

@Skalakid it's probably connected with parser - input is not the same as output and we are not highlighting then

[thienlnam]

We've reverted the offending PR #35837, so this is no longer a blocker

[robertKozik]

Cannot reproduce it on staging, will look into it further

[tgolen]

I'm going to close this since the PR which caused the regression was reverted.