[HOLD for payment 2024-03-29] [QAB] Optimistically update the QAB NVP when taking actions

[Gonals]

HELD on https://github.com/Expensify/Expensify/issues/377599

When taking one of the QAB-assignable actions, we want to optimistically set the QAB on the frontend, as described in this section of the design doc.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010994abf23e96432d
• Upwork Job ID: 1767200034860355584
• Last Price Increase: 2024-03-11

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010994abf23e96432d

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[Gonals]

OFF HOLD

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Set Quick Action NVP optimistically #38386

If no regressions arise, payment will be issued on 2024-03-29. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[CortneyOfstad]

@eVoloshchak can you clarify whether or not this needs a regression test by EOD today?

[CortneyOfstad]

Payment Summary

@eVoloshchak to be paid $500 via NewDot

[eVoloshchak]

Regression Test Proposal

1. Log into newDot
2. Request money from someone and choose manual.
3. Open the Console and go to Application > IndexedDB > OnyxDB > keyValuePairs
4. Confirm nvp_quickActionGlobalCreate is set to requestManual
5. Repeat steps 1-4, but choosing Scan. Confirm nvp_quickActionGlobalCreate is set to requestScan
6. Repeat steps 1-4, but choosing Distance. Confirm nvp_quickActionGlobalCreate is set to requestDistance
7. Repeat steps 1-4, but splitting the request between several people. Confirm nvp_quickActionGlobalCreate is set to split Manual.

Do we agree 👍 or 👎

[CortneyOfstad]

Regression test created here — https://github.com/Expensify/Expensify/issues/384210

[JmillsExpensify]

$500 approved for @eVoloshchak based on summary.