[HOLD for payment 2024-04-17] [$250] [Simplified Collect][Taxes] Incorrect numpad horizontal padding on the native and mweb devices

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.54-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Break down in numbered steps

1. Have Collect workspace supported in NewDot
2. Go to Settings
3. More feature
4. Turn on Tax feature
5. Go to taxes
6. Add new tax rate
7. Add value

Expected Result:

Describe what you think should've happened

The numpad should have same styles as amount numpad in money request flow or new distance rate flow

Actual Result:

Describe what actually happened

the numpad has horizontal padding

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a628ba28191722d3
• Upwork Job ID: 1769837087142653952
• Last Price Increase: 2024-03-18
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0
• Krishna2323 | Contributor | 0

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a628ba28191722d3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Upwork job price has been updated to $250

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect numpad horizontal padding on the native and mweb devices

What is the root cause of that problem?

styles.mh5 is added to AmountForm wrapping view.

App/src/components/AmountPicker/AmountSelectorModal.tsx

Line 39 in 5770e23

<ScrollView contentContainerStyle={[styles.flex1, styles.mh5, styles.mb5]}>

What changes do you think we should make in order to solve the problem?

Remove styles.mh5 and add style={styles.mh5} to Button only. We also need to wrap Button with View inside ScrollView.

App/src/components/AmountPicker/AmountSelectorModal.tsx

Line 40 in 5770e23

<View style={styles.flex1}>

Result

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@Krishna2323 thanks, thats looking good, can you please raise a PR and for the screenshots, can you always include screenshot of the tax screen next to the money request flow on the same platform to compare the styles and verify its the same?

[Krishna2323]

sure will add both screenshots for comparison, raising a PR asap.

[Krishna2323]

@abdulrahuman5196, PR ready for review.

[abdulrahuman5196]

Reviewing now

[trjExpensify]

PR hit staging earlier today.

[melvin-bot]

This issue has not been updated in over 15 days. @lschurr, @mountiny, @abdulrahuman5196, @Krishna2323 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[Krishna2323]

PR was deployed to production yesterday, Melvin. 🙃

[lschurr]

Payment summary:

• Contributor: @Krishna2323 $250 (paid in Upwork)
• Contributor+ @abdulrahuman5196 $250 (paid in Upwork)