-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [TS migration] Migrate IOURequestStepTaxRatePage and IOURequestStepTaxAmountPage pages to TypeScript #38915
Comments
This issue is internal and will be handled by the TS team. |
Triggered auto assignment to @kevinksullivan ( |
Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue! |
Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@kevinksullivan When you get a minute, could you assign me to the issue for future payment? I reviewed the linked PR. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
This is deployed to prod already. |
@kevinksullivan Friendly bump for payment! 🙏 |
@rlinoz, @kevinksullivan, @jjcoffee Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Job added to Upwork: https://www.upwork.com/jobs/~01bd5245d23e9e6994 |
Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new. |
Offer sent @jjcoffee lmk when you accept! |
@kevinksullivan Accepted, thanks! |
@kevinksullivan Whilst I have you, could you also process payment on #38584? It's been hanging around for a while, I think it's dropped off your radar because the automation failed. Thanks 🙏 |
yup, will do. All set here as well |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
Issue Owner
Current Issue Owner: @kevinksullivanIssue Owner
Current Issue Owner: @kevinksullivanIssue Owner
Current Issue Owner: @kevinksullivanUpwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: