[Guided setup] [$250] Login - "Woohoo! All caught up." message appears instead of the "Welcome to Expensify" modal

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.61.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4481382&group_by=cases:section_id&group_id=229043&group_order=asc
Issue reported by: Applause - Internal Team

Action Performed:

1. Start logging in with a new Gmail account
2. Copy the magic link, paste it to iCloud notes and add "staging" to it
3. Open it from iCloud notes
4. Switch back to the first tab

Expected Result:

"Welcome to Expensify" modal should appear

There should be Concierge chat in the LHN

Actual Result:

"Woohoo! All caught up." message appears instead of the "Welcome to Expensify" modal

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442656_1712601054217.WFOT6467.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bb9b4c17e55d927b
• Upwork Job ID: 1777819519501967360
• Last Price Increase: 2024-05-04

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[trjExpensify]

@tienifr @DylanDylann this is in the regression period. Can you take a look?

[tienifr]

Checking.

[tienifr]

I don't think this is related to my PR. The empty UI and welcome modal is completely different. So the empty UI would never block the welcome modal from display. I think the root cause is that the welcome modal hasn't covered the case when user logged in using magic deep link.

Also on first login, Concierge chat should always show but in this case it doesn't. It seems like another issue.

So the correct issue for this is: Welcome modal does not show on login using magic deep link.

[tienifr]

I think we should tag the author of onboarding flow or the welcome modal here to take a look.

[trjExpensify]

Cool, have done here. CC: @mountiny

[mountiny]

asking QA to retest if its not deploy blocker actually

[mountiny]

QA confirmed this is not deploy blocker. I feel like we can do nothing here and just focus on getting the stage1 onboarding done asap

[trjExpensify]

Where's the Concierge DM for a new sign-up?

[mountiny]

Discussing here

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bb9b4c17e55d927b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[mountiny]

This seems to be only happening on mWeb safari and for the fresh sign up.

The welcome modal should be shown and the concierge chat should show up too, exporting.

[ikevin127]

Doing some digging I figured that this is definitely related to the [Onboarding - Stage 1] Onboarding Flow PR.
#39907 issue already has a draft PR based on this proposal which removes the now legacy hasSelectedChoice variable from the hasRequiredOnyxKeysBeenLoaded check.

This should be fixing the display of the welcome modal based on this logic, which would also trigger the creation of the first Concierge chat. The problem is that I tested this hypothesis and the issue is still happening (non-consistently) - so the mentioned draft PR won't fix this issue.

[trjExpensify]

@filip-solecki are you guys working on this?

[filip-solecki]

I think we can wait until new Onboarding flow is merged and recheck if this is reproducible

[trjExpensify]

Popped a hold in the title for that PR!

[melvin-bot]

@trjExpensify, @mountiny, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

Still holding

[mountiny]

Still on hold

[melvin-bot]

@trjExpensify, @mountiny, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

This can come off hold now, as #39687 is merged. @filip-solecki can you take a look and confirm?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mountiny]

Is this still reproducible @alitoshmatov @lanitochka17 ?

[melvin-bot]

@trjExpensify, @mountiny, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@trjExpensify @mountiny @alitoshmatov this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

@trjExpensify, @mountiny, @alitoshmatov 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[trjExpensify]

Issue is no longer reproducible, closing Melv.