-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yellow boxes make developers anxious and potentially less productive #4014
Comments
Triggered auto assignment to @lschurr ( |
😂 This is great. Honestly, I think we have put off on ignoring them since we were maybe hoping to fix them. But I'm not against ignoring these particular warnings if we are not going to do anything about them. |
I am looking into upgrading to Animated 2 #3972 |
@parasharrajat Thanks for the info. I'm going to prepare a PR for those boxes, and I'll remove the reanimated filter as this should be decided in #3972. |
Although I have to admit I don't have scientific evidence to back up this generalizing assertion, I have found that those yellow warnings:
Action Performed:
Launch the app on a mobile device in Dev mode.
Expected Result:
No anxiety.
Actual Result:
An anxiety spike.
Workaround:
Discussion
Logs are important and require attention, so ignoring all logs would certainly be a bad idea. But letting these pop is bad for DX. Here is what I propose to handle each warning:
rn-fetch-blob
. A fix would require to upgrade to a maintained fork such as react-native-blob-util. Suggestion: ignore the log until this lib is dropped; optionally open a ticket to migrate.react-navigation
, see discussion. Suggestion: ignore the log, and create a low-priority issue to track it down.As a general rule, I suggest when a new warning raises, one should:
Platform:
iOS
Android
I'll be happy to address this as a gift to Expensify during my upwork job.
The text was updated successfully, but these errors were encountered: