[$250] [HOLD for payment 2024-05-06] Group - Wrong number of members seen on group details page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Click on FAB > Start chat
3. Search for 2 non-existing users and click on add to group
4. Create the group
5. Open the group details page and observe the number besides "Members" button

Expected Result:

Correct number of members is visible, in this case 3

Actual Result:

Incorrect number of members is seen, in this case 5

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453424_1713433895585.bandicam_2024-04-18_12-47-48-931.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014cb2f3679812b245
• Upwork Job ID: 1790118403758641152
• Last Price Increase: 2024-05-13

Issue Owner

Current Issue Owner: @

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this bug might be related to #vip-vsb

[allgandalf]

Not reproducible on staging

Screen.Recording.2024-04-18.at.8.28.23.PM.mov

[rlinoz]

Hmm I can

Screen.Recording.2024-04-18.at.12.05.03.mov

I think we are not clearing the optimistic created participants?

[rlinoz]

Ooh I think this is part of moving away from participantAccountIDs to participants. The participantAccountIDs has only 3 members.

cc: @marcaaron since I think you were handling this?

[rlinoz]

Anyway, this happens only for accounts that are created on this flow and the main functionality is working as intended, so I don't think this should be a blocker. Removing the label.

[allgandalf]

Ooh I think this is part of moving away from participantAccountIDs to participants. The participantAccountIDs has only 3 members.

Should we use report?.participantAccountIDs instead then ?

[rlinoz]

Should we use report?.participantAccountIDs instead then ?

No, that is being deprecated here #34692.

[rlinoz]

I still need to investigate to check if this is a backend bug

[marcaaron]

We should be clearing the optimistic accountIDs after inviting here:

https://github.com/Expensify/Web-Expensify/blob/6fe504f9aa17f8a3945bd4e2ba1fe2b155f5011a/lib/ReportAPI.php#L5949-L5967

We could check the logs though to make sure the params are correct and nothing happened to the Auth request

[rlinoz]

Seems like we are not sending the optimistic accountID list, will finish the PR tomorrow.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixes member count in group chat when creating it #40939

If no regressions arise, payment will be issued on 2024-05-06. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rlinoz] The PR that introduced the bug has been identified. Link to the PR:
• [@rlinoz] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rlinoz] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rlinoz] Determine if we should create a regression test for this bug.
• [@rlinoz] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rlinoz]

@johncschuster @ahmedGaber93 reviewed the PR.

[johncschuster]

Thanks, @rlinoz!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014cb2f3679812b245

[melvin-bot]

Current assignee @ahmedGaber93 is eligible for the External assigner, not assigning anyone new.

[johncschuster]

Summary:
Contributor+: @ahmedGaber93 $250 - Upwork Offer - PAID! 🎉