CRITICAL: [Actionable Whisper] [$1500] Create workspace automatically if none already exists for Categorize and Share

[quinthar]

Problem:

The Categorize and Share actionable whispers require a workspace to work. When you choose this option, it takes you to a workspace selector. At the bottom is a Learn more button that takes you to the workspace list. However:

1. Learn more isn't a very powerful call to action -- it's a little confusing why you would want to learn more about a workspace when you didn't ask for one and there's no indication that a workspace is related to the thing you just tried to do.
2. Additionally, even after you create one, you are just looking at the profile for it -- it's not clear why your new workspace helps you share with an accountant or categorize.

Solution:

Remove the empty workspace state from this workflow (ie, Learn more and Create workspace), and instead:

1. Create a workspace automatically if none already exists
2. And then take you straight to the thing you said you wanted to do:
   • Categorize should take you straight to the expense editor with the category selector open,
   • Share with accountant should take you straight to the invite screen of the workspace editor

If you already have an existing workspace, we'll keep the flow the same.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01df6ab75f9b8c1e2d
• Upwork Job ID: 1782840102150389760
• Last Price Increase: 2024-04-23
• Automatic offers:
• shubham1206agra | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01df6ab75f9b8c1e2d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[melvin-bot]

Upwork job price has been updated to $1500

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[thienlnam]

I'm setting the price this high due to the urgency associated with this. We'd like to have this completed and merged in the next couple of days. Please do not submit a proposal unless you can spend your full time working on this

[thienlnam]

We'll probably have a C+ take up internal implementation

[allroundexperts]

Hi @Krishna2323!
I am on it already. This is no longer open for proposals.

[Krishna2323]

Please do not submit a proposal unless you can spend your full time working on this

@allroundexperts, ok, thanks for the info, I was confused by the comment.

[allroundexperts]

Created a draft PR: #40840

[melvin-bot]

This issue has not been updated in over 15 days. @allroundexperts, @thienlnam, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Triggered auto assignment to @isabelastisser (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[thienlnam]

This issue is ready to be paid out

C: @allroundexperts
C+: Shared between @ishpaul777 / @shubham1206agra

[melvin-bot]

This issue has not been updated in over 15 days. @allroundexperts, @thienlnam, @isabelastisser, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[isabelastisser]

Sorry, I missed this because of the monthly label. Working on the payments now.

[isabelastisser]

Payment summary:

Contributor role: @allroundexperts $1500 to be manually paid via NewDot PENDING
C+ role: Shared between @ishpaul777 / @shubham1206agra

C+ @ishpaul777 - $750 to be paid via Upwork
C+ @shubham1206agra - $750 to be paid via Upwork

[shubham1206agra]

Payment summary:

Contributor role: @allroundexperts $1500 to be manually paid via NewDot PENDING C+ role: Shared between @ishpaul777 / @shubham1206agra

C+ @ishpaul777 - $750 to be paid via Upwork C+ @shubham1206agra - $750 to be paid via Upwork

@isabelastisser Can you hold this payment for a moment?
You can process @allroundexperts's payment though.

[isabelastisser]

@shubham1206agra, can you please provide some context as to why the payment needs to be held? Thanks!

[shubham1206agra]

I need to discuss payment division with @thienlnam first.

[thienlnam]

There were a couple PRs required for this issue, and since @shubham1206agra reviewed did most of the reviewing it probably does not constitute a fair split. @shubham1206agra has suggested a 1250 / 250 split - is that fine with you @ishpaul777?

[ishpaul777]

I believe there were only 2 PRs one was reviewed by me and the other by @shubham1206agra. I personally feel fair split is 50-50

[shubham1206agra]

Nope, there were 2 PRs. But both didn't have the same complexity (2nd has more complex logic). And I co-reviewed the 1st PR and caught a major regression, which otherwise went unnoticed by you.

Given this, I feel the split I suggested is fair.

[thienlnam]

@isabelastisser We've settled on a split amount.
1000 to @shubham1206agra and 500 to @ishpaul777

[isabelastisser]

All set!

[shubham1206agra]

@isabelastisser I still haven't received any payment.

[isabelastisser]

@shubham1206agra , I see that you accepted the offer now, so I processed the payment now. Thanks!

[JmillsExpensify]

$1,500 approved for @allroundexperts