Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop - Chat - User name is not displayed when initiating chat for the first time #4075

Closed
kavimuru opened this issue Jul 15, 2021 · 7 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Launch the app and login
  2. Click the green fab button select New Chat
  3. Search for a user who has expensify account but haven't chatted before.
  4. Click on that user to initiate chat

Expected Result:

User name is displayed on the chat conversation page

Actual Result:

User name is not displayed on the chat conversation page

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android ✔️
Desktop App ✔️
Mobile Web ✔️

Version Number:
1.0.78-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5152909_Recording__968.mp4

Bug5152909_Screen_Shot_2021-07-15_at_8 26 33_AM

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Jul 15, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Jag96
Copy link
Contributor

Jag96 commented Jul 16, 2021

It looks like this is also related to https://github.com/Expensify/Auth/pull/5747, for new chats when we call API.GetReportSummaryList, the returned data is an empty set, which means we are never setting the participants data here.

I confirmed by checking the return value for two different reportIDs, one that has chat data in it and one that contains no data using the format https://www.expensify.com/api?command=Get&returnValueList=reportSummaryList&reportIDList=REPORT_ID_HERE

Since this is going to be an internal fix, assigning myself and making it internal.

@Jag96 Jag96 assigned Jag96 and unassigned jasperhuangg Jul 16, 2021
@Jag96 Jag96 added Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review labels Jul 16, 2021
@marcaaron
Copy link
Contributor

Sorry / thanks again @Jag96 (I'm writing tests next time 😭 )

@Jag96
Copy link
Contributor

Jag96 commented Jul 16, 2021

Auth PR was merged, after the Auth deploy this will be resolved

@AndrewGable
Copy link
Contributor

@Jag96 / @marcaaron - Can you confirm this fix is live since Auth was deployed and we can close this?

@marcaaron
Copy link
Contributor

Yes, it's working for me now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants