-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat - User mention is not highlighted as mention when mentioning someone in edited comment #40861
Comments
Triggered auto assignment to @adelekennedy ( |
Triggered auto assignment to @madmax330 ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think this issue might be related to the #vip-vsb. |
This is technically not in production so its not a blocker but I agree this should be addressed in the PR |
We are going to revert this PR #35226 and @dukenv0307 can you please work on implementing this in there too as I think it should be part of the initial implementation (it looks weird when you choose the mention and its not saved that way) |
@madmax330 @adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
I see the new Pr links this issue so I think we can close it for now |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
The user mention in the edited message will be highlighted as mention.
Actual Result:
The user mention in the edited message is not highlighted as mention.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6459940_1713948778458.mention_2.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: