[Payment due 2024-05-14][$250] iOS - Track expense - Swiping to right on invite page does not return to workspace chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.65-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #40740
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to self DM.
3. Go to + > Track expense.
4. Create a track scan expense.
5. From the whisper, select Share it with my accountant.
6. Select a workspace > Click Submit.
7. Tap back button on the Invite member RHP.
8. Note that it returns to the workspace chat.
9. Repeat Step 3 to 6.
10. Instead of using the back button, swipe to right (iOS) to dismiss the invite page.

Expected Result:

App will return to workspace chat.

Actual Result:

App returns to self DM.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460161_1713958475686.RPReplay_Final1713957671.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b51c4bf06d4563af
• Upwork Job ID: 1790541614263488512
• Last Price Increase: 2024-05-15

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[mountiny]

Seems like this is coming from #40740 that did not fix the flow completely @bernhardoj can you please follow up with fix for this? could not assign you without you commenting here. Thanks!

[bernhardoj]

It's decided to leave it as oos since we don't have a confirmation yet.

cc: @jjcoffee

[jjcoffee]

Yeah this was an issue from the original PR that implemented actionable whispers and it was decided to fix as a follow-up polish.

[bernhardoj]

@jjcoffee So, should we apply this?

[jjcoffee]

@bernhardoj Yes I believe so. Would you mind reposting the video here as a proposal? Just to keep things tidy.

@thienlnam can you add the Bug label and assign @bernhardoj? Thanks 🙏

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @thienlnam is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[bernhardoj]

Here is the video:

Screen.Recording.2024-04-23.at.10.25.59.mov

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

PR is ready

cc: @jjcoffee

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: N/A - this is a polish issue
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open a self DM
2. Track a new expense
3. Wait for the concierge message and choose Share with my accountant
4. Select any workspace and confirm
5. Verify you are navigated to the invite page
6. Web/Desktop: Verify the chat behind the invite page is the workspace chat
7. Android/iOS/mWeb: Go back using the swipe gesture or hardware back button and verify the workspace chat is shown

Do we agree 👍 or 👎

[jjcoffee]

@kadiealexander This hit production May 7, so should be due payment today. 🙇

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b51c4bf06d4563af

[melvin-bot]

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

[kadiealexander]

Payouts due:

• Contributor: $250 @bernhardoj
• Contributor+: $250 @jjcoffee

Upwork job is here.

[jjcoffee]

@kadiealexander Offer accepted, thanks! 🙏