-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search v1] "__fake__" is displayed at From and To fields for split expenses #41796
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it. |
Triggered auto assignment to @roryabraham ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@roryabraham FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
not a blocker - hidden feature |
@grgia this is still happening. I think the query we have for sharedReports is incorrect |
I can take this one @roryabraham, since it's related to Search |
cool |
@luacmartins Huh... This is 4 days overdue. Who can take care of this? |
Still happening in some instances. I have another PR in review to filter report types and I need to work on another issue for tracked expenses too. |
@luacmartins Huh... This is 4 days overdue. Who can take care of this? |
I think this should be solved by https://github.com/Expensify/Auth/pull/10927 too, since the reportID used for these split transactions is -2 and we'll filter these out, showing only the 1:1 transactions created from the split. |
@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Hmm so that PR didn't solve this issue. Gonna work on a separate fix. |
@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick! |
1 similar comment
@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I think we can close this one for now since the PR was merged. Maybe we'll have another edge case of this issue, but we can reopen it then. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.71.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #41615
Action Performed:
Expected Result:
Fields should be populated with valid data
Actual Result:
"fake" is displayed at From and To fields for split expenses
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: