Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TS error #41932

Closed
luacmartins opened this issue May 9, 2024 · 2 comments
Closed

Fix TS error #41932

luacmartins opened this issue May 9, 2024 · 2 comments
Assignees
@luacmartins @lschurr
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented May 9, 2024 •
edited
Loading

Problem

We have @ts-expect-error TODO: Remove this once TestHelper (https://github.com/Expensify/App/issues/25318) is migrated to TypeScript in many places throughout our tests -- 135 occurrences as of today, example. We should fix the TS error and remove that comment.
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 9, 2024
@luacmartins luacmartins self-assigned this May 9, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 9, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@luacmartins luacmartins mentioned this issue May 9, 2024
Merged
60 tasks
@luacmartins
Copy link
Contributor Author

Closing this in favor of #39130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@lschurr lschurr

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luacmartins @lschurr