Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2024-05-29] Anonymous session not created on deep-linking to specific comments in public rooms #41948

Closed
marcochavezf opened this issue May 9, 2024 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review

Comments

@marcochavezf
Copy link
Contributor

marcochavezf commented May 9, 2024

When you deep-link to a specific comment in a public room, it asks you to sign in (ie, it doesn't show you the public room with an anonymous account).

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013caae7ec700ad741
  • Upwork Job ID: 1795943315996286976
  • Last Price Increase: 2024-05-29
@marcochavezf marcochavezf added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 9, 2024
@marcochavezf marcochavezf self-assigned this May 9, 2024
Copy link

melvin-bot bot commented May 9, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@alexpensify
Copy link
Contributor

@marcochavezf - should we assign this one as internal? Also, what Wave is this associated with? Thanks!

@ishpaul777
Copy link
Contributor

Hey 👋 , Can i be assigned here for PR review #41949

@marcochavezf
Copy link
Contributor Author

This bug was reported from an internal channel and I think vip-vsb should be the correct associated project.

@marcochavezf
Copy link
Contributor Author

Update: PR merged and deployed to staging #41949 (comment)

@marcochavezf marcochavezf moved this to CRITICAL in [#whatsnext] #vip-vsb May 15, 2024
@marcochavezf
Copy link
Contributor Author

Assigning @ishpaul777 for C+ review payment once the PR is deployed to production + 7 days

@alexpensify alexpensify removed the Bug Something is broken. Auto assigns a BugZero manager. label May 17, 2024
@alexpensify alexpensify removed their assignment May 17, 2024
@alexpensify alexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label May 17, 2024
Copy link

melvin-bot bot commented May 17, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@alexpensify
Copy link
Contributor

Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.

@strepanier03 - While I'm offline, I need help here completing the payment process after this one clears the 7-day period. Thanks!

@quinthar quinthar moved this from CRITICAL to HIGH in [#whatsnext] #vip-vsb May 20, 2024
@strepanier03
Copy link
Contributor

Still on staging so waiting for hold to start.

@strepanier03
Copy link
Contributor

Deployed to production 2024-05-22, 7-day hold begins. Hold ends on 2024-05-29, I'll update the title.

@strepanier03 strepanier03 changed the title Anonymous session not created on deep-linking to specific comments in public rooms [HOLD for payment 2024-05-29] Anonymous session not created on deep-linking to specific comments in public rooms May 23, 2024
@strepanier03 strepanier03 added Weekly KSv2 Daily KSv2 and removed Daily KSv2 Weekly KSv2 labels May 23, 2024
@alexpensify
Copy link
Contributor

@strepanier03 - was everyone paid here? I'm back online and seeing if I need to take over. Thanks!

Copy link

melvin-bot bot commented May 29, 2024

Payment Summary

Upwork Job

BugZero Checklist (@alexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@alexpensify
Copy link
Contributor

I'm taking over as the BZ member here again. I realized that I mixed up my days and thought the 29th was Monday. I'm back on track now and I'll complete the next steps.

@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013caae7ec700ad741

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-05-29] Anonymous session not created on deep-linking to specific comments in public rooms [$250] [HOLD for payment 2024-05-29] Anonymous session not created on deep-linking to specific comments in public rooms May 29, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

@alexpensify alexpensify changed the title [$250] [HOLD for payment 2024-05-29] Anonymous session not created on deep-linking to specific comments in public rooms [$500] [HOLD for payment 2024-05-29] Anonymous session not created on deep-linking to specific comments in public rooms May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

Upwork job price has been updated to $500

@alexpensify
Copy link
Contributor

@ishpaul777 - please accept the invite in Upwork and I can complete the payment process. Thanks!

@ishpaul777
Copy link
Contributor

Thanks! Accepted offer, i would appreciate if you leave a written public feedback,(just helps to grow my visibily on upwork)

@alexpensify
Copy link
Contributor

Closing - I've completed the payment process in Upwork. Sorry, @ishpaul777, I missed the note to add a comment, but I typically leave the highest stars. Noted for the next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review
Projects
No open projects
Development

No branches or pull requests

4 participants