[HOLD for payment 2024-05-22] Login - 'Another login page is open' briefly displayed when refresh the page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.73-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Enter the email on the email field and continue
2. Click on "Go Back"
3. Refresh the page

Expected Result:

No 'Another login page is open' is displayed

Actual Result:

'Another login page is open' briefly displayed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479253_1715600330476.bandicam_2024-05-13_14-30-48-787.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[amyevans]

I confirmed that the bug is coming from #40997 by commenting out this line locally:

App/src/libs/ActiveClientManager/index.ts

Line 62 in 21e69b3

window.addEventListener('beforeunload', cleanUpClientId);

I'll leave it to you @tgolen though to decide if it's better to revert the PR or just handle this bug as a follow up. Thanks!

[tgolen]

Thanks for the initial investigation! I don't think this needs to be a blocker.

[Skakruk]

@tgolen I guess, we can add a flag, that client is in progress of cleaning its ID from active clients list and return true for isClientTheLeader in this case.

[bondydaa]

@tgolen can you also make sure to remove the Web DeployBlocker as well (I guess we've started add 2 blocker labels)

[tgolen]

@Skakruk OK, that sounds like a good idea.

[Skakruk]

@tgolen should I create a new PR, following the whole flow?

[tgolen]

Yes, please.

[Skakruk]

@tgolen here is the PR #42095

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Keep original isClientTheLeader value on page refresh #42095

If no regressions arise, payment will be issued on 2024-05-22. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@tgolen] The PR that introduced the bug has been identified. Link to the PR: Fix ActiveClientManager doesn't track the currently active tab well and needs improved #40997
• [@tgolen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix ActiveClientManager doesn't track the currently active tab well and needs improved #40997 (comment)
• [@tgolen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a no discussion necessary
• [@tgolen] Determine if we should create a regression test for this bug. NO
• [@tgolen] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[miljakljajic]

Can we close?

[melvin-bot]

@tgolen, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ishpaul777]

hey @miljakljajic, I reviewed the PR for this one Can we please reopen for payment?