-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-10] [$500] Task – Task is bold in LHN when reassign task to another user and @ appears before user name #42068
Comments
Triggered auto assignment to @AndrewGable ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it. |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsp |
@AndrewGable can you determine if this is something from the API or not? if not can you remove the DeployBlocker label? |
Yes, looking into it |
I can't figure out which PR introduced the bug 🕵️ @bondydaa - Am I correct that this is the latest diff for Web deploy? https://github.com/Expensify/Expensify/issues/394485 |
Seems like yes, that was the diff, which should not have caused this, so seems fine to not block on API deploy. |
Ok can't reproduce bug on production or staging, can we retest this @lanitochka17 ? Screen.Recording.2024-05-13.at.5.05.52.PM.mov |
Issue is still reproducible bandicam.2024-05-15.20-45-25-144.mp4 |
Triggered auto assignment to @laurenreidexpensify ( |
Job added to Upwork: https://www.upwork.com/jobs/~015ad0a78be0f06131 |
Triggered auto assignment to @adelekennedy ( |
@adelekennedy adding you here for parental leave sub. no action required this BZ this week, PR is still in review, but adding you for payment in coming weeks when the fix makes it to prod. Thanks |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-10. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Friendly bump @adelekennedy for payment |
Just took care of it! @getusha it looks like your offer is still pending - will yo accept it today? Otherwise it expires! |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: [@suneox / @getusha] The PR that introduced the bug has been identified. Link to the PR: N/a i think this is an edge case left unhandled |
Accepted, @adelekennedy, thanks! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.73-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4553777
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Action Performed:
Go to https://staging.new.expensify.com/
Log in
Open any chat and select Assign task
Create a task and assign to another user
Find task in the LHN
Open task details and reassign task to another user
Observe the task in LHN
Expected Result:
Task details is not bold in LHN when reassign task to another user, as this page is open
Actual Result:
Task details is bold in LHN when reassign task to another user and wait until @ appears before user name in LHN
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6479248_1715599916453.bold.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @adelekennedyThe text was updated successfully, but these errors were encountered: