[HOLD for payment 2024-06-13] [$250] Split - Split menu RHP header does not show the updated scanning message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.73-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Submit a scan expense
4. Submit one more expense if there is only one expense
5. Go to transaction thread of the scan expense
6. Note that header shows the updated copy "Receipt scan in progress. Check back later or enter the details now."
7. Split expense with the same user
8. Click on the split preview

Expected Result:

The split menu RHP header should follow the same header copy in scan expense transaction thread

Actual Result:

The split menu RHP header does not follow the same header copy in scan expense transaction thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479390_1715607461442.20240513_212753.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012fbf011aa919798f
• Upwork Job ID: 1790067935670882304
• Last Price Increase: 2024-05-13
• Automatic offers:
• nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@tgolen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-split

[bondydaa]

@tgolen can you determine if this is something from the API or not? if not can you remove the DeployBlocker label?

[tgolen]

I don't think this comes from the API, but I think the reproduction is too much of an edge case to be a blocker.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012fbf011aa919798f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The split menu RHP header does not follow the same header copy in scan expense transaction thread

What is the root cause of that problem?

Here

App/src/pages/iou/SplitBillDetailsPage.tsx

Line 104 in 97097ff

description={translate('iou.receiptStatusText')}

we still use the outdated copy for scanning.

We made the UI update here, but we didn't update it for SplitBillDetailsPage.

What changes do you think we should make in order to solve the problem?

1. Here

   App/src/pages/iou/SplitBillDetailsPage.tsx

   Line 104 in 97097ff

   description={translate('iou.receiptStatusText')}

   we should use translate('iou.receiptScanInProgressDescription') instead to be consistent

2. We can update the title to use Icon too, like we did with the MoneyRequestHeader here

3. To make sure the style looks correct, we'll also need to pass a variable to control the flexGrow1 here, and do not apply that flexGrow1 when using MoneyRequestHeaderStatusBar in SplitBillDetailsPage. There might be other minor style adjustments.

Or instead of this, we can just wrap <MoneyRequestHeaderStatusBar /> inside a View

What alternative solutions did you explore? (Optional)

NA

[allgandalf]

Regression from #40020

[nkdengineer]

Nope it's not a regression, the UI of SplitBillDetailsPage has always been that way. It's just another part we need to update to be consistent.

[anmurali]

This does not sound like a bug. I think it is a design inconsistency but I do think it is worth fixing. Let's reuse the Receipt scan in progress. Check back later or enter the details now. language in both places.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@allroundexperts this PR is ready for preview

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Split menu RHP header does not show the updated scanning message #42338

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@tgolen, @anmurali, @allroundexperts, @nkdengineer Huh... This is 4 days overdue. Who can take care of this?

[tgolen]

Bump @allroundexperts @anmurali to complete the checklist.

[melvin-bot]

@tgolen, @anmurali, @allroundexperts, @nkdengineer 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[anmurali]

@nkdengineer is paid. Waiting for @allroundexperts to complete the BZ checklist to approve his payment via ND

[allroundexperts]

On the checklist now!

[allroundexperts]

Checklist

1. I wasn't able to point to a single PR that caused this. It seems like this was the case since the beginning.
2. N/A
3. N/A
4. A regression test should be helpful here. The steps given in the OP are straightforward and can be used to create a regression test.

[melvin-bot]

@tgolen, @anmurali, @allroundexperts, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[anmurali]

Payment summary approved

• @nkdengineer $250 on upwork
• @allroundexperts $250 on ND

[JmillsExpensify]

$250 approved for @allroundexperts