[HOLD for payment 2024-05-22] Chat - After marking a message as unread, sending a new message causes the chat to scroll up

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.73-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4555724&group_by=cases:section_id&group_order=asc&group_id=296775
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Open a chat
2. Mark a message as Unread
3. Send a message

Expected Result:

After marking a message as unread, sending a new message should not cause the chat to scroll up it should maintain the current position

Actual Result:

After marking a message as unread, sending a new message causes the chat to scroll up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479669_1715623190988.2024-05-13_22-52-09.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@tylerkaraszewski FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[ikevin127]

Looking into this as we speak since I authored PR #41448.
Will get back with a response regarding whether this was caused by my PR and if so I'll handle the follow-up.

[bondydaa]

sounds like this is not related to the API so removing the web deploy blocker label, this should also hep us figure out if it was your PR (or another app PR) or not.

[ikevin127]

I confirm it's caused by my PR. Will open a follow-up PR today with the fix.

[Beamanator]

Revert PR merged, requesting CP 🙏

[tylerkaraszewski]

I don't see a CP request in #deployer @Beamanator ?

[yuwenmemon]

This has been fixed here: #42167 (comment)

[Beamanator]

Fixed, so closing 👍 This issue has been linked in #35011, the original implementation PR, so we know to fix this bug in the next PR 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert: [NewFeature] Automatic scrolling to the top of report's new unread message marker #42167

If no regressions arise, payment will be issued on 2024-05-22. 🎊