[HOLD for payment 2024-06-05] [$250] Chat - PDF file blinks when open it

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.73-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41802

Action Performed:

1. Open the app and log in
2. Open any report
3. If there are no PDF attachments in chat, send a PDF
4. Open the PDF

Expected Result:

There is no blinking when opening a PDF file

Actual Result:

PDF file blinks while opening it regardless of size

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479696_1715624789229.IMG_6850.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0186b254f5f9f3fc2c
• Upwork Job ID: 1790379082807984128
• Last Price Increase: 2024-05-14
• Automatic offers:
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[CortneyOfstad]

Was able to recreate! Getting some eyes on this:

RecordIt-1715694475.MP4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0186b254f5f9f3fc2c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The PDF blinks when opening it.

What is the root cause of that problem?

The loading comes from the PDF component when it's loading the pdf source.

App/src/components/PDFView/index.native.tsx

Lines 135 to 138 in a6cb60c

	<PDF
	fitPolicy={0}
	trustAllCerts={false}
	renderActivityIndicator={() => <FullScreenLoadingIndicator />}

The reason it shows twice is, that when the loading is complete, we render the pdf component without the pressable,

App/src/components/PDFView/index.native.tsx

Lines 163 to 176 in a6cb60c

	return onPress && !successToLoadPDF ? (
	<PressableWithoutFeedback
	onPress={onPress}
	style={[themeStyles.flex1, themeStyles.alignSelfStretch, !failedToLoadPDF && themeStyles.flexRow]}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.IMAGEBUTTON}
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	accessibilityLabel={fileName || translate('attachmentView.unknownFilename')}
	>
	{renderPDFView()}
	</PressableWithoutFeedback>
	) : (
	renderPDFView()
	);
	}

so a new instance of PDF component is created because the component tree is changed and the loading starts again. The reason we don't want the pressable is because the PDF component already handles the onpress.

App/src/components/PDFView/index.native.tsx

Line 144 in a6cb60c

onPageSingleTap={onPress}

What changes do you think we should make in order to solve the problem?

Disable the pressable instead of rendering it without pressable when the load completes, just like what we did before #21714.
disabled={successToLoadPDF}

[CortneyOfstad]

@mananjadhav we have a proposal above for review — thanks!

[mananjadhav]

@bernhardoj 's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @mananjadhav

[mananjadhav]

Thanks I'll take a look today.

[CortneyOfstad]

Thanks @mananjadhav!

[mananjadhav]

The PR is straight forward but it seems it causes issues with scroll on Android. Put up a discussion in the PR comments here

[CortneyOfstad]

Thanks @mananjadhav! Just a heads up that we're on a merge freeze until Wednesday 👍

[CortneyOfstad]

Merge freeze is planned to end today 🤞

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix pdf blinks when open it #42333

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR: [HOLD for payment 2023-07-24] [$1000] Android - Attachment - Unable to scroll PDF files in preview #20867
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment https://github.com/Expensify/App/pull/21714/files#r1623515775:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A, it was a bug.
• [@mananjadhav] Determine if we should create a regression test for this bug. I don't think we need a regression test for this.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[CortneyOfstad]

Payment Summary

@bernhardoj — paid $250 via Upwork
@mananjadhav — to be paid $250 via NewDot

Thanks!

[JmillsExpensify]

$250 approved for @mananjadhav