[HOLD] CRITICAL: reportAction chain is broken in rooms and expense reports

[muttmuure]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

What performance issue do we need to solve?

e.g. memory consumption, storage read/write times, React native bridge concerns, inefficient React component rendering, etc.

reportActions continue to break getOlderActions under specific circumstances, which we need to fix holistically

What is the impact of this on end-users?

List specific user experiences that will be improved by solving this problem e.g. app boot time, time to for some interaction to complete, etc.

If getOlderActions fails, we do not load the full chat history or expense report history, and the chat history flickers infinitely:

List any benchmarks that show the severity of the issue

Please also provide exact steps taken to collect metrics above if any so we can independently verify the results.

I've reported it here: https://expensify.slack.com/archives/C05LX9D6E07/p1715709384419139?thread_ts=1715699398.771909&cid=C05LX9D6E07

Proposed solution (if any)

Please list out the steps you think we should take to solve this issue.

@janicduplessis is working on a PR here which we believe will fix all known issues: #41962

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

Note: These should be the same as the benchmarks collected before any changes.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on Upwork

[melvin-bot]

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

[muttmuure]

Still in need of a fix:

[roryabraham]

We're discussing in slack - trying to push forward a proposal here

[melvin-bot]

@roryabraham Eep! 4 days overdue now. Issues have feelings too...

[roryabraham]

This is essentially a dupe of #41254 btw, so I'm making both CRITICAL and putting this one on HOLD since Janic is also assigned to the other one and we're working together on it.

[melvin-bot]

@roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[roryabraham]

Remains tied for my top priority, still on HOLD. Updates in slack

[melvin-bot]

@roryabraham Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@roryabraham 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@roryabraham 10 days overdue. Is anyone even seeing these? Hello?

[roryabraham]

Recent activity in #41962, latest updates starting here

[melvin-bot]

@roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@roryabraham 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@roryabraham Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[muttmuure]

Not overdue

[muttmuure]

Fixed!