Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Workspace button text during pending account validation #4236

Closed
1 of 5 tasks
luacmartins opened this issue Jul 26, 2021 · 6 comments
Closed
1 of 5 tasks

Update Workspace button text during pending account validation #4236

luacmartins opened this issue Jul 26, 2021 · 6 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@luacmartins
Copy link
Contributor

Coming from here.


Action Performed:

  1. Open a Workspace with a PENDING account
  2. The button text is set to Get Started.
  3. After validating the 3 amounts, the button still says Get Started.

Expected Result:

  1. Before validation the button text should be set to Finish Setup.
  2. After validation the button text should be set to Manage Cards and clicking it should direct the user to expensify.com

Actual Result:

  1. Before validation the button text is set to Get Started.
  2. After validation the button text is set to Get Started and clicking it opens a blank modal.

Workaround:

  1. The button text does not affect the workflow, but is confusing.
  2. The user can refresh the page.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

@MelvinBot
Copy link

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MelvinBot
Copy link

@luacmartins Eep! 4 days overdue now. Issues have feelings too...

@MelvinBot
Copy link

@luacmartins Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@MelvinBot
Copy link

@luacmartins 10 days overdue. I'm getting more depressed than Marvin.

@luacmartins
Copy link
Contributor Author

Stop complaining Melvin!

@luacmartins
Copy link
Contributor Author

PR #4237 deployed to production. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants