Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Workspace - Account title is not displaying on Export out-of-pocket expenses as #43130

Closed
6 tasks done
kbecciv opened this issue Jun 5, 2024 · 20 comments
Closed
6 tasks done
Assignees
Labels
Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Jun 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.79-7
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #42561
Issue reported by: Applause - Internal Team

Action Performed:

  1. Sign in to any applause.expensifail.com domain account
  2. Create a new workspace
  3. Connect to QBO with [email protected] (1password)
  4. Do not sync
  5. Go to Workspace > Accounting
  6. Click on Export > Export company cards as > Account
  7. Verify that if there is no account to select then a message "No accounts found" is displayed
  8. Notice Accounts payable title is not displaying and not on header

Expected Result:

Accounts payable should be displayed

Actual Result:

Account title is not displaying on Export out-of-pocket expenses as

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6502761_1717593569409.2024-06-05_18-01-08.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ef0ff96f7581526a
  • Upwork Job ID: 1798406753219738599
  • Last Price Increase: 2024-06-05
Issue OwnerCurrent Issue Owner: @jjcoffee
@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 5, 2024
Copy link

melvin-bot bot commented Jun 5, 2024

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Jun 5, 2024

We think that this bug might be related to #wave-collect - Release 1

@kavimuru
Copy link

kavimuru commented Jun 5, 2024

@hayata-suenaga tagging you as per this comment

@neil-marcellini
Copy link
Contributor

Looks like a frontend bug

@neil-marcellini neil-marcellini added External Added to denote the issue can be worked on by a contributor and removed DeployBlocker Indicates it should block deploying the API labels Jun 5, 2024
@melvin-bot melvin-bot bot changed the title Workspace - Account title is not displaying on Export out-of-pocket expenses as [$250] Workspace - Account title is not displaying on Export out-of-pocket expenses as Jun 5, 2024
Copy link

melvin-bot bot commented Jun 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ef0ff96f7581526a

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 5, 2024
Copy link

melvin-bot bot commented Jun 5, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Jun 5, 2024

I can't reproduce this. What account are we using to connect to QBO here @kbecciv? Can you please include that in your steps?

Kapture.2024-06-05.at.11.17.43.mp4

@kavimuru
Copy link

kavimuru commented Jun 5, 2024

@yuwenmemon I have updated the original post.

  1. Sign in to any applause.expensifail.com domain account
  2. Create a new workspace
  3. Connect to QBO with [email protected] (1password)
  4. Do not sync
  5. Go to Workspace > Accounting
  6. Click on Export > Export company cards as > Account
  7. Verify that if there is no account to select then a message "No accounts found" is displayed
  8. Notice Accounts payable title is not displaying and not on header

@hayata-suenaga
Copy link
Contributor

I think this is a pusher issue. It's possible for the client to miss pusher events.

I think these pusher events are sent from the Integration Server, which we don't have reliable updates 😓

@yuwenmemon
Copy link
Contributor

@kavimuru How can one connect to QBO and not sync? Can you post a video of you doing that?

@hayata-suenaga
Copy link
Contributor

I think this is kind of same as this one

@kavimuru
Copy link

kavimuru commented Jun 5, 2024

@yuwenmemon here is the video.

2024-06-06.00-51-48.1.mp4

@yuwenmemon
Copy link
Contributor

Hmmm... Odd I'm still not able to reproduce 🤔
Screenshot 2024-06-05 at 2 30 31 PM

Could this possibly have been related to Onyx Updates being turned off maybe?

@yuwenmemon
Copy link
Contributor

Anyway, regardless this does not seem to be a blocker to me as I'm unable to reproduce on both accounts on staging, and it would most likely be due to a back-end issue anyway.

@yuwenmemon yuwenmemon added Daily KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Jun 5, 2024
@yuwenmemon yuwenmemon added Hourly KSv2 Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Jun 5, 2024
@roryabraham roryabraham added Daily KSv2 and removed Hourly KSv2 labels Jun 6, 2024
@hayata-suenaga
Copy link
Contributor

@kbecciv
Copy link
Author

kbecciv commented Jun 8, 2024

Issue is not reproducible

2024-06-08.13-23-22.mp4

@melvin-bot melvin-bot bot added the Overdue label Jun 8, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

@yuwenmemon, @jjcoffee Huh... This is 4 days overdue. Who can take care of this?

@jjcoffee
Copy link
Contributor

@yuwenmemon I think we can close this?

@melvin-bot melvin-bot bot removed the Overdue label Jun 12, 2024
@yuwenmemon
Copy link
Contributor

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

7 participants