[HOLD for payment 2024-07-17] report.errorFields.notFound is being cleared incorrectly

[arosiclair]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: Latest
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @arosiclair
Slack conversation: #35671 (comment)

Action Performed:

1. Create a workspace
2. Create a workspace room
3. Copy the URL
4. Log in as a non-workspace member
5. Visit the room URL
6. Verify a not found page displays
7. Invite the user to the workspace

Expected Result:

The not found error is cleared by an update from the backend

Actual Result:

We're clearing the error using a side effect in ReportScreen here.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

N/A

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[arosiclair]

errorFields.notFound gets set by OpenReport when the report doesn't exist or you don't have access to it. It gets cleared on success here but we should also clear it when the report gets shared to the user and we push it with an Onyx update. We can do that by updating Report::structureReportForOnyx. Once that's done we can remove this side effect.

[puneetlath]

Makes sense @arosiclair. Will you raise a PR?

[arosiclair]

Yup this is just low priority for me atm. I'll get to it soon

[arosiclair]

PR's are ready just have to wait for the Auth PR to be deployed before posting the App PR. ETA is end of next week.

[puneetlath]

Is there any App aspect to this? Or it's al back-end?

[arosiclair]

Yeah we're removing App code in this PR.

[arosiclair]

Already part of #newdot-quality here

[melvin-bot]

@puneetlath @arosiclair this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove clearReportNotFoundErrors #44184

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove clearReportNotFoundErrors #44184

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@shubham1206agra friendly reminder about the checklist so we can pay tomorrow.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@puneetlath, @arosiclair, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too...

[puneetlath]

@shubham1206agra bump on the checklist.

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Add possibility to leave from workspaces and workspace expense chats #35671
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add possibility to leave from workspaces and workspace expense chats #35671 (comment)
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@shubham1206agra] Determine if we should create a regression test for this bug. Yes
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. [User A] Log in as workspace admin
2. [User A] Create a room
3. [User A] Copy the URL and send it to user B.
4. [User B] As a non-workspace member, go to the URL
5. [User B] Verify a Not Found screen displays
6. [User A] As the admin, invite the user to the room
7. [User B] Verify the Not Found screen is removed and the non-member can see the room

• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@shubham1206agra I sent you an offer: https://www.upwork.com/nx/wm/offer/103254802

Please ping me here when you've accepted.

[puneetlath]

Regression test update: https://github.com/Expensify/Expensify/issues/415177

[shubham1206agra]

@puneetlath Accepted

[puneetlath]

Paid, thanks!