[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] App crashes upon connecting to QuickBooks Online

[francoisl]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.81-7
Reproducible in staging?: Yes
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Me
Slack conversation:

Action Performed:

1. Create a workspace
2. Connect it to QuickBooks Online

Expected Result:

The initial connection flow should complete and the UI sync indicator should disappear.

Actual Result:

The app crashes at some point during the sync flow.

Workaround:

Refreshing the page.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-06-10.at.6.42.11.PM.mov

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[francoisl]

cc @aldo-expensify or @hayata-suenaga in case you know if it's a known issue (though I didn't find one). Going to keep internal for now in case it was already known and being worked on.

[francoisl]

Ok interestingly at some point in the initial sync, the policy object in WorkspaceMoreFeaturesPage doesn't have a config, so a simple config?.syncTax here should fix it. I'll send a PR shortly.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent crash when connecting to QuickBooks Online #43451

If no regressions arise, payment will be issued on 2024-06-18. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@francoisl] The PR that introduced the bug has been identified. Link to the PR:
• [@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@francoisl] Determine if we should create a regression test for this bug.
• [@francoisl] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent crash when connecting to QuickBooks Online #43451

If no regressions arise, payment will be issued on 2024-06-20. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@francoisl] The PR that introduced the bug has been identified. Link to the PR:
• [@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@francoisl] Determine if we should create a regression test for this bug.
• [@francoisl] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[francoisl]

This was all handled internally from an internal issue, no payments required.