Desktop - Chat - Timezone information not updated after language change

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue was found when executing the PR #4309

Action Performed:

1. Login to the app using expensifail account
2. Change your language to Spanish
3. Open any chat
4. Timezone information in the chat will be shown

Expected Result:

Timezone information in the chat gets updated right away

Actual Result:

Timezone information in the chat gets updated only after refresh

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Android
• Desktop App
• Mobile Web

Version Number:
1.0.82-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5175290_Recording__1001.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

Should be handled by #4218. Trace to back to #4309. It's a regression.

[nkuoch]

@parasharrajat The PR you linked to is already in staging, and is the PR that was stated as responsible in this issue description.
However, I've tried reverting it locally, and it doesn't seem to work either, so this PR is probably not responsible.
The issue on staging (and that can be reproduced locally) is actually worse than the original issue of just not being able to refresh the timezone. Now, changing the language doesn't refresh anything on the page.

[parasharrajat]

@nkuoch That PR has added few lines which is causing this issue.

Original that PR was created to show the timezone info when we change the language to other than English but after that PR is merged Now time is not changing in real-time. So literally, it should be part of that PR.

But if you don't want it be fixed as part of that PR, I have a fix.

We need to enable prop checking in shouldComponentUpdate

[nkuoch]

If you have a fix, yes please make a new PR, I can review it, thanks!

[nkuoch]

Doing a Git bisect, this seems to be the PR that introduced the bug of texts not being refreshed to the right language. cc @kidroca

[parasharrajat]

Ok. Great find. That is going to be a regression from #4253. even if we revert the PR. I see this issue will persist bcz of this

    shouldComponentUpdate(nextProps, nextState) {
        return nextState.localTime !== this.state.localTime;
    }

It should block the update if Props changes which will block the text update on language change. Instead of this, We can simply use PureComponent or

    shouldComponentUpdate(nextProps, nextState) {
        return !_.isEqual(nextProps, this.props) || nextState.localTime !== this.state.localTime;
    }

I am submitting a PR to correct this and we can raise another issue about the bad behaviour of #4253.

[parasharrajat]

@nkuoch #4359 For reference.

[nkuoch]

@kidroca Please comment on this issue so I can assign it to you. When your PR is ready, we'll need to add the CP Staging label to your PR before merging it, so it gets automatically cherry picked to staging, and so the blocker label can be removed from here.

[kidroca]

@nkuoch 👍
I'm about to submit a PR, will reference this ticket as well

[roryabraham]

@kavimuru @isagoico Can we retest this in 1.0.82-3 or higher please?

[isagoico]

Retest was a pass in all platforms 🎉