[HOLD for payment 2024-06-28] Multi tags - Error shows up when disabling "Required" toggle

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.83-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: exp around https://expensify.testrail.io/index.php?/tests/view/4631261
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• Workspace is set up with multi dependant tags.
• "People must tag expenses" is disabled on Old Dot.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Tags.
3. Click on any tag.
4. Disable "Required" toggle.

Expected Result:

The "Required" toggle can be disabled.

Actual Result:

The "Required" toggle cannot be disabled. It shows "An error occurred while updating the tag, please try again." when disabling "Required" toggle.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6513002_1718359195522.bandicam_2024-06-14_17-53-50-694.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 1

[rlinoz]

So, the expected result here should be to hide the Required toggle, the same way we do in prod, because dependent tag lists cannot be required.

Let me try to find what changed.

[rlinoz]

It seems we added the Required toggle in the release actually..

https://github.com/Expensify/App/pull/42972/files#diff-ce5c00d5f79ceacf688251ea2b0874a9e5f9055ec14022b854cfd58f0354f887R237-R248

In OldDot we don't show the required toggle if we have dependent tags

cc: @hayata-suenaga

[rlinoz]

Removing blocker since this is not a main flow and required dependent tags.

[jayeshmangwani]

@adelekennedy Please assign me to the issue here for tracking the payment

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hides required toggle in case dependent tags is enabled #43769

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jayeshmangwani] Determine if we should create a regression test for this bug.
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jayeshmangwani]

• The PR that introduced the bug has been identified. Link to the PR: Add a switch for requiring tags on the multi level tags RHP #42972
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add a switch for requiring tags on the multi level tags RHP #42972 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Enabled dependent tags in OldDot by importing a CSV and unchecking the Are these independent tags? checkbox
2. In NewDot go to Workspace > Tags > Settings and check that Members must tag all expenses
3. Now select a tag
4. Verify that no required toggle is shown
5. Go back to OldDot, import a CSV and keep Are these independent tags? checked
6. In NewDot select a tag
7. Verify that the required toggle is visible and we can toggle it

Do we agree 👍 or 👎

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @jayeshmangwani owed $250 via NewDot

BugZero Checklist (@adelekennedy)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[adelekennedy]

Payouts due:

• Contributor+: $250 @jayeshmangwani (NewDot)

[adelekennedy]

https://github.com/Expensify/Expensify/issues/409497

[jayeshmangwani]

Requested $250 on NewDot.

[JmillsExpensify]

$250 approved for @jayeshmangwani