Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show a loading spinner in place of the Get Started button copy during VBA flow #4384

Closed
kevinksullivan opened this issue Aug 2, 2021 · 6 comments
Assignees
Labels
Daily KSv2 Reviewing Has a PR in review

Comments

@kevinksullivan
Copy link
Contributor

Problem

When a user enters information at certain steps where we make an API call, and thus there is a brief loading period, we show a loading spinner in the right pane modal they are actively in, and the button in the background used to set up a VBA or manage cards.
image

Solution

Do not show a loading spinner for the button, even in a circumstance where the right pane is loading. Instead, make sure that the button always remains consistent with what it said when first selecting it (Get Started or Finish Setup).

@MelvinBot
Copy link

@stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MelvinBot
Copy link

@stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

@stitesExpensify
Copy link
Contributor

This has been merged, just waiting on deploy

@MelvinBot
Copy link

@stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

@MelvinBot
Copy link

@stitesExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@kevinksullivan
Copy link
Contributor Author

on prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

3 participants