Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payment Card / Subscription] iOS - "Add Payment Card" button is blinking when changing currency in app #44118

Closed
1 of 6 tasks
lanitochka17 opened this issue Jun 20, 2024 · 15 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.86-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #43317

Action Performed:

  1. Access the New Expensify Beta app
  2. Sign into a valid account
  3. Go to staging.new.expensify.com/settings/subscription/add-payment-card (You may need a beta access account to locate this page)
  4. Change the currency and observe the bottom green button

Expected Result:

User expects the button to stay normal when changing currency

Actual Result:

The button is flashing when the currency is changed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6519757_1718912768810.Subscription_button_is_blinking_on_iOS_app_.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @narefyev91
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 20, 2024
Copy link

melvin-bot bot commented Jun 20, 2024

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jun 20, 2024
@mountiny
Copy link
Contributor

@fabioh8010 this is still behind beta so not a blocker but should be handled

@mountiny mountiny moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jun 20, 2024
@mountiny mountiny moved this from Release 2: Summer 2024 (Aug) to Polish in [#whatsnext] #wave-collect Jun 20, 2024
@mountiny
Copy link
Contributor

Raised in Slack

@trjExpensify
Copy link
Contributor

@fabioh8010 this is still behind beta so not a blocker but should be handled

FYI, there's no beta for this. It's only accessible if you know the URL though, so effectively hidden. :)

@narefyev91
Copy link
Contributor

Hey! I'm Nicolay from Callstack - will work on this flow - please assign it for me. Thanks!

@trjExpensify trjExpensify changed the title iOS - "Add Payment Card" button is blinking when changing currency in app [Payment Card / Subscription] iOS - "Add Payment Card" button is blinking when changing currency in app Jun 20, 2024
@trjExpensify
Copy link
Contributor

Assigned!

@narefyev91 narefyev91 mentioned this issue Jun 21, 2024
50 tasks
@blimpich blimpich assigned blimpich and unassigned thienlnam Jun 21, 2024
@blimpich
Copy link
Contributor

Picking this up as I'm managing the other issues that are being addressed by this PR, figured I should pick this up too.

Copy link

melvin-bot bot commented Jun 25, 2024

@blimpich, @narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jun 25, 2024
Copy link

melvin-bot bot commented Jun 27, 2024

@blimpich, @narefyev91 Huh... This is 4 days overdue. Who can take care of this?

@blimpich
Copy link
Contributor

not overdue, PR was merged, waiting auto-close

Copy link

melvin-bot bot commented Jul 1, 2024

@blimpich, @narefyev91 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Jul 3, 2024

@blimpich, @narefyev91 10 days overdue. Is anyone even seeing these? Hello?

Copy link

melvin-bot bot commented Jul 5, 2024

@blimpich, @narefyev91 12 days overdue. Walking. Toward. The. Light...

@blimpich
Copy link
Contributor

blimpich commented Jul 5, 2024

Closing as the fix for this reached production.

@blimpich blimpich closed this as completed Jul 5, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 5, 2024
@github-project-automation github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants