[HOLD for payment 2024-07-26] [CSV] Add Download action to Search page

[rlinoz]

We should complete this section of the doc.

This will add the Download option to the bulk action button in the Search page and effectively download the file.

It is important to handle the offline modal and the modal for errors as well.

Issue Owner

Current Issue Owner: @JmillsExpensify

[trjExpensify]

@filip-solecki can you comment here so I can assign you before I pop labels on it?

[filip-solecki]

Hi! I am Filip from SWM an expert agency and I'd like to work on this!

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[JmillsExpensify]

Looks like we're still waiting on the PR.

[trjExpensify]

The PR for #44577 merged this morning, so taken this off hold. 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add Export CSV and handle offline for all actions #45614
• Fix adding exported report action when downloading CSV #45642

If no regressions arise, payment will be issued on 2024-07-26. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @filip-solecki does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[rushatgabhane]

1. Log in to the account with some expenses
2. Go to search
3. Select a few items
4. Click on "X selected" button
5. Click "Download"
6. When offline you should see Modal with information otherwise the file will be downloaded and contain the selected items

[rlinoz]

Oh I think we are good, this is a new functionality and we just asked for the testing steps to be created in Testrails

https://github.com/Expensify/Expensify/issues/414444

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot
• Contributor: @filip-solecki is from an agency-contributor and not due payment

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

Payment summary above is accurate. This is part of a broader initiative, so we'll handle the regression test centrally. @rushatgabhane please submit an expense via New Expensify!

[trjExpensify]

Confirming the payment summary as follows:

• $250 to @rushatgabhane for the C+ review.

[JmillsExpensify]

$250 approved for @rushatgabhane

[melvin-bot]

@JmillsExpensify, @luacmartins, @rushatgabhane, @filip-solecki Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@JmillsExpensify, @luacmartins, @rushatgabhane, @filip-solecki Still overdue 6 days?! Let's take care of this!

[JmillsExpensify]

All payments made and regression steps are being added centrally.