Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250 BLOCKED BY #44388] Send invoice - Invoice report appears broken #44992

Closed
6 tasks done
lanitochka17 opened this issue Jul 8, 2024 · 33 comments
Closed
6 tasks done
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.5-4
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Send invoice
  3. Enter amount and select a receiver
  4. Enter merchant and send the invoice
  5. In invoice chat, click on the preview

Expected Result:

The invoice report will not appear broken

Actual Result:

The invoice report appears broken

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6536110_1720458016359.20240709_005813.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011040101d9617db1c
  • Upwork Job ID: 1810478196050638059
  • Last Price Increase: 2024-07-09
Issue OwnerCurrent Issue Owner: @akinwale
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@carlosmiceli FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@carlosmiceli
Copy link
Contributor

Looking into it now.

@carlosmiceli carlosmiceli removed the DeployBlocker Indicates it should block deploying the API label Jul 8, 2024
@carlosmiceli
Copy link
Contributor

I think this is the culprit: #44529

@carlosmiceli
Copy link
Contributor

Mmmm maybe not.

@carlosmiceli carlosmiceli added the External Added to denote the issue can be worked on by a contributor label Jul 9, 2024
@carlosmiceli
Copy link
Contributor

Can't figure out yet which PR may be the culprit, but can confirm that it's a FE issue, so I'll add the External label for now to see if we get proposals.

@melvin-bot melvin-bot bot changed the title Send invoice - Invoice report appears broken [$250] Send invoice - Invoice report appears broken Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011040101d9617db1c

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@carlosmiceli
Copy link
Contributor

This one could also be related: #43036

@VickyStash
Copy link
Contributor

This one could also be related: #43036

@carlosmiceli This PR was reverted several days ago: #44891

@lakchote
Copy link
Contributor

lakchote commented Jul 9, 2024

@lanitochka17 is the expected result correct?

Shouldn't it read:

The invoice report will be appear broken
+ The invoice report will not appear broken

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Jul 9, 2024
@Julesssss Julesssss added Daily KSv2 and removed Hourly KSv2 labels Jul 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
@carlosmiceli
Copy link
Contributor

You're weird Melvin.

@carlosmiceli carlosmiceli added Weekly KSv2 and removed Daily KSv2 labels Jul 16, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 16, 2024
@cristipaval
Copy link
Contributor

@carlosmiceli , this issue might have the same root cause as this one

We can put a hold on and test it when the other is closed.

@carlosmiceli
Copy link
Contributor

Yeah, there's a few issues in parallel about this, sounds good!

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

This issue has not been updated in over 15 days. @carlosmiceli, @akinwale eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@rayane-d
Copy link
Contributor

PR is merged

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2024
@carlosmiceli
Copy link
Contributor

Will wait on the next KI retest, we may close after that.

@carlosmiceli carlosmiceli added Weekly KSv2 and removed Monthly KSv2 labels Sep 25, 2024
@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2024
@carlosmiceli carlosmiceli added Monthly KSv2 and removed Weekly KSv2 labels Sep 25, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Fourth week)

@melvin-bot melvin-bot bot added the Overdue label Oct 30, 2024
@carlosmiceli carlosmiceli added Weekly KSv2 and removed Monthly KSv2 labels Oct 30, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2024
@carlosmiceli carlosmiceli added Monthly KSv2 and removed Weekly KSv2 labels Oct 30, 2024
@carlosmiceli
Copy link
Contributor

Seems like we can close this, we'll reopen if it reappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants