[HOLD FOR PAYMENT 10/1][$250] [Guided Setup Stage 3] Update the Pay w/ Expensify selectors

[deetergp]

Part of the Extend Onboarding to Invited Users project

Main issue: https://github.com/Expensify/Expensify/issues/392615
Doc section: https://docs.google.com/document/d/1EX1tKSkhffpqP4TXD7iKIPKWnU5U8ELv32j-QTtXH2g/edit#heading=h.pnxf7cla3pn
Project: #wave-collect

Feature Description

When a user is invited to NewDot from an IOU, we initially assume they are going to be splitting bills and assign them the newDotSplitChat choice and an inviteTye of iou on their nvp_introSelected, but we want to wait till they select a payment type before we send them their onboarding message. If they select:

• "Pay with Business Bank Account" we want to
  • Send them the newDotManageTeam onboarding message
  • Optimistically set nvp_introSelected
    • choice to newDotManageTeam
    • isInviteOnboardingComplete to true
• "Pay with Personal Bank Account" or "Pay with Debit Card" we want to
  • Send them the newDotSplitChat message
  • Optimistically set nvp_introSelected
    • isInviteOnboardingComplete to true

When a user is invited to NewDot from an invoice, we initially assume they are going to be managing expenses for a team and give them the newDotManageTeam choice and an inviteType of invoice on their nvp_introSelected, but we want to wait till they select a payment type before we send them their onboarding message. If they select:

• "Pay as an Individual" we want to
  • Send them the newDotSplitChat onboarding message
  • Optimistically set nvp_introSelected
    • choice to newDotSplitChat
    • isInviteOnboardingComplete to true
• "Pay as a Business" we want to
  • Send them the newDotManageTeam message
  • Optimistically set nvp_introSelected
    • isInviteOnboardingComplete to true

Manual Test Steps

Note: These won't be manually testable till the following backend GHs are done and deployed
https://github.com/Expensify/Expensify/issues/411150
https://github.com/Expensify/Expensify/issues/411149
https://github.com/Expensify/Expensify/issues/411148
https://github.com/Expensify/Expensify/issues/411146

See the Pays an IOU or invoice via VBBA and Pays an IOU or invoice via Elsewhere/PBA/Debit/Credit sections from the doc.

Automated Tests

If possible, add tests to assert that

• Users with nvp_introSelected.inviteType: iou that click the "Pay With Business Bank Account" button end up with nvp_introSelected.choice: newDotManageTeam and nvp_introSelected.isInviteOnboardingComplete: true and are sent the newDotManageTeam onboarding message.
• Users with nvp_introSelected.inviteType: invoice that click the "Pay as an Individual" button end up with nvp_introSelected.choice: newDotSplitChat and nvp_introSelected.isInviteOnboardingComplete: true and are sent the newDotSplitChat onboarding message.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841133888555964659
• Upwork Job ID: 1841133888555964659
• Last Price Increase: 2024-10-01

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[trjExpensify]

Confirming who from SWM is taking this here: https://expensify.slack.com/archives/C036QM0SLJK/p1720631312670319?thread_ts=1720454141.387759&cid=C036QM0SLJK

[cdOut]

Hi, I’m Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I’ll be working on this issue.

[deetergp]

Hi @cdOut, thanks for taking this on!

[melvin-bot]

@deetergp, @CortneyOfstad, @cdOut Huh... This is 4 days overdue. Who can take care of this?

[cdOut]

Waiting for the backends.

[deetergp]

I'm working on the PR to send the message to non-IOU/Invoice customers and should have that wrapped tomorrow. Once it's doen this should be very easy to complete shortly thereafter. Hoping to have it done tomorrow afternoon.

[deetergp]

@cdOut The PR to push nvp_introSelected to onyx when invited users sign in for the first time has been deployed to staging, so you should be able to at least work with that NVP. It got too late in the day for a Friday to deploy the back end changes to handle. I think you can test your changes with Report.completeOnboarding without any backend changes to CompleteGuidedSetup, the only piece missing is that we won't updated the NVP in the backend. I am going to ask our Aussie employees to deploy the back end changes on their Monday morning, which should still be Sunday night for you in CEST. I'll let know one way or another if it happens or not.

Edit: I've also added a couple bits to your section of the doc. I realized we need to decided if we will eventually be changing their NVP choice on the frontend, since that's when we decide which message we are going to send, so I updated the end of this section.

And I also realized that, while we are planning on reusing an existing message from CONST.ONBOARDING_MESSAGES the one we want to reuse is for newDotEmployer but we'll be calling it for newDotSubmit so I added a new section for CONST here.

[cdOut]

@deetergp I'll look over the changes to the docs and try out the nvp_introSelected, could you also update me if the rest of the backend changes have been pushed to staging also?

[deetergp]

@cdOut The backend changes for this have been deployed. It has has been updated to handle updating the NVP changes when an IOU-invited user selects BBA and an Invoice-invited user selects anything other than BBA. It should also send the onboarding message for any IOU or Invoice invited user despite which payment type they choose. Please test away and let me know if you hit any speed bumps along the way. Thanks!

[cdOut]

Thank you, I'll test and add the recent changes to the doc and see if all works well. Will ping you if I have any further questions.

[cdOut]

I worked on it yesterday and will continue today, both issues should be ready for review sometime tomorrow.

[deetergp]

Looking forward to it @cdOut, thanks!

[deetergp]

This ended up getting fixed and merged last Friday.

[CortneyOfstad]

@deetergp to confirm, payment is needed here? If so, standard for @DylanDylann as @cdOut is with SM? TIA!

[CortneyOfstad]

@deetergp bump on the above ^^^ thank you!

[deetergp]

@CortneyOfstad Sorry! Yes, you are correct, standard for @DylanDylann. @cdOut is with SWM.

[DylanDylann]

@CortneyOfstad Please help to handle payment here. Thanks

[CortneyOfstad]

Sorry for missing this as I was OoO — getting the payments sorted now!

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021841133888555964659

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[CortneyOfstad]

Sorry the ping ^^^ Had to apply the external label to get the job post to be created!

[CortneyOfstad]

@DylanDylann I just sent you an offer via Upwork here — please let me know once you accept and I will get that paid ASAP. Thanks!

[DylanDylann]

@CortneyOfstad I accepted it, thank you

[CortneyOfstad]

Payment Summary

@DylanDylann — paid $250 via Upwork
@cdOut — contracted position