[HOLD for payment 2024-07-26] [$125] Expensify Card - There are two error messages when trying to proceed without a limit

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.6-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Expensify Card (enable in More features)
3. Click Issue new card
4. Proceed to Step 4 - Set a limit
5. Click Next without entering anything

Expected Result:

There will be one error message when trying to proceed without a limit

Actual Result:

There are two error messages when trying to proceed without a limit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538913_1720700812914.20240711_202403.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018df7767f83b2a4f8
• Upwork Job ID: 1811791404789871853
• Last Price Increase: 2024-07-12
• Automatic offers:
• DylanDylann | Reviewer | 103096366
• nkdengineer | Contributor | 103096369

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are two error messages when trying to proceed without a limit

What is the root cause of that problem?

We don't pass shouldHideFixErrorsAlert into FormProvider to hide the fix error alert. Then we have two errors, one is the amount input error, and one is the form error.

App/src/pages/workspace/card/issueNew/LimitStep.tsx

Line 80 in 105dce5

<FormProvider

What changes do you think we should make to solve the problem?

Pass shouldHideFixErrorsAlert as true into FormProvider as we do in other places that use AmountForm input

App/src/pages/workspace/card/issueNew/LimitStep.tsx

Line 80 in 105dce5

<FormProvider

What alternative solutions did you explore? (Optional)

[Julesssss]

Not a blocker

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018df7767f83b2a4f8

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @jliexpensify is eligible for the Bug assigner, not assigning anyone new.

[mountiny]

@DylanDylann what do you think of the proposal?

[melvin-bot]

Upwork job price has been updated to $125

[DylanDylann]

@mountiny reviewing now

[DylanDylann]

This is straightforward. @nkdengineer's proposal looks good to me

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: There are two error messages when trying to proceed without a limit #45388

If no regressions arise, payment will be issued on 2024-07-26. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@DylanDylann] Determine if we should create a regression test for this bug.
• [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Payment Summary

• C: @nkdengineer $125

Upwork job

[mountiny]

@DylanDylann will be paid separately for the entire project

Checklist is not required here as we are working on this new feature which caused this bug

[jliexpensify]

Thanks Vit, fixed summary!

[jliexpensify]

Paid and job closed!