Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Report preview not updated properly when an imported personal card expense automatically merges with a scanned receipt. #46553

Open
1 of 6 tasks
m-natarajan opened this issue Jul 31, 2024 · 22 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction(Don't have card expense to check)
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722272910444839

Action Performed:

  1. Submit a card expense report with receipt
  2. Open the report as approver (This is report 6565029153383101)
    (Scanned receipt automatically merges with the card expense)

Expected Result:

Only one expense displayed with scanned receipt

Actual Result:

2 expenses displayed and both eReceipt and scanned receipt displayed. In Olddot displayed only one expense.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Screenshot 2024-07-29 at 1 07 56 PM

image (4)

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 31, 2024
Copy link

melvin-bot bot commented Jul 31, 2024

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@puneetlath
Copy link
Contributor

@VictoriaExpensify I would bet this is a back-end issue. And this seems like a #wave-collect thing to me.

@JmillsExpensify JmillsExpensify moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Jul 31, 2024
@VictoriaExpensify
Copy link
Contributor

Thanks for the input, Puneet. Attempting to reproduce.

@VictoriaExpensify
Copy link
Contributor

Oh ok, I just caught up on the Slack thread here and it looks like we've determined this has happened because we haven't officially added NewDot support for personal cards yet.

It looks like this will be a higher priority in Nov so I think we should just add the internal label and bump this one out to weekly for now.

@puneetlath - let me know if you think we need to do something different here.

@VictoriaExpensify VictoriaExpensify added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 and removed Daily KSv2 Weekly KSv2 labels Aug 2, 2024
@puneetlath
Copy link
Contributor

Sounds good 👍🏾 . I'd also add the Hot Picks label.

Copy link

melvin-bot bot commented Aug 14, 2024

@VictoriaExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 6, 2024
@VictoriaExpensify VictoriaExpensify added the Hot Pick Ready for an engineer to pick up and run with label Sep 10, 2024
@VictoriaExpensify
Copy link
Contributor

Not overdue, coming back to this in November

@melvin-bot melvin-bot bot removed the Overdue label Sep 10, 2024
@VictoriaExpensify VictoriaExpensify changed the title Report preview not updated properly when an imported personal card expense automatically merges with a scanned receipt. [HOLD] Report preview not updated properly when an imported personal card expense automatically merges with a scanned receipt. Sep 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 11, 2024
@VictoriaExpensify
Copy link
Contributor

On hold, not OD

@melvin-bot melvin-bot bot removed the Overdue label Oct 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
@VictoriaExpensify
Copy link
Contributor

Not OD

@melvin-bot melvin-bot bot removed the Overdue label Nov 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2024
@VictoriaExpensify
Copy link
Contributor

Not OD

@melvin-bot melvin-bot bot removed the Overdue label Dec 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 23, 2025
@VictoriaExpensify VictoriaExpensify added Daily KSv2 and removed Monthly KSv2 labels Jan 28, 2025
@melvin-bot melvin-bot bot removed the Overdue label Jan 28, 2025
@VictoriaExpensify
Copy link
Contributor

Moving back to daily so we can test if this is still reproducable

@melvin-bot melvin-bot bot added the Overdue label Jan 31, 2025
@VictoriaExpensify
Copy link
Contributor

Needs reproducing

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 3, 2025
@VictoriaExpensify VictoriaExpensify removed the Internal Requires API changes or must be handled by Expensify staff label Feb 6, 2025
@VictoriaExpensify
Copy link
Contributor

I've asked Applause to retest - https://expensify.slack.com/archives/C9YU7BX5M/p1738818682964909

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 6, 2025
@VictoriaExpensify
Copy link
Contributor

Irina has advised:

We can't submit a card expense report with receipt, because this issue still reproducible
#48597

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 11, 2025
@VictoriaExpensify
Copy link
Contributor

I need to figure out what we need to do to try and reproduce this

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 14, 2025
Copy link

melvin-bot bot commented Feb 17, 2025

@VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Feb 19, 2025

@VictoriaExpensify Eep! 4 days overdue now. Issues have feelings too...

@VictoriaExpensify
Copy link
Contributor

I've been working on some higher priority issues, I'll come back to this one.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 20, 2025
Copy link

melvin-bot bot commented Feb 25, 2025

@VictoriaExpensify Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Feb 27, 2025

@VictoriaExpensify Still overdue 6 days?! Let's take care of this!

@VictoriaExpensify
Copy link
Contributor

Not ID

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Needs Reproduction Reproducible steps needed
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

4 participants