[HOLD for payment 2024-11-14] [$250] [Android] mWeb/Chrome - BNP - Inserting decimal point, inconsistent behavior in mweb&Android

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.18
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4836262
Issue reported by: Applause Internal Team

Action Performed:

1. Launch app in both mweb and Android
2. Tap fab -- submit expense
3. Enter 23 and keep cursor between 2&3 and type dot to insert decimal point
4. Note the behavior in mweb & Android

Expected Result:

Inserting decimal point, behavior must be consistent in mweb& Android.

Actual Result:

In Android, decimal point is inserted correctly in the same place but in mweb, decimal point is inserted after a number. Inserting decimal point, inconsistent behavior in mweb& Android.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6565332_1723101158572.Screenrecorder-2024-08-08-12-34-45-180_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846593217215177350
• Upwork Job ID: 1846593217215177350
• Last Price Increase: 2024-10-16

Issue Owner

Current Issue Owner: @thesahindia

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[IuliiaHerets]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mallenexpensify]

Gonna try to pawn this off on Sheena when she gets assigned another iOS bug :)

[mallenexpensify]

Oh snap.... we got an Android phone on the way to the bank! I'll be able to test soon.

[melvin-bot]

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mallenexpensify]

Need to get Android phone setup, will do next week, bumped to Daily

[mallenexpensify]

Unsure when in the office this week but planning to get phone setup

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Still need to get phone setup 😿

[flodnv]

Sounds goo, go for it @rezkiy37 👍

[rezkiy37]

I am OOO till Tuesday and will continue to work on this issue later.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix current selection for web TextInputWithCurrencySymbol #51325

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

@thesahindia @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @rezkiy37 is from an agency-contributor and not due payment
• Reviewer: @thesahindia owed $250 via NewDot

BugZero Checklist (@mallenexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1846593217215177350/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[mallenexpensify]

@thesahindia can you complete the checklist plz?

[mallenexpensify]

@thesahindia plz complete the BZ checklist.

[thesahindia]

We just need to add a test case. The steps are below:

1. Launch the app in mWeb
2. Tap at the "+" icon > Submit expense
3. Enter any random number, e.g., 123
4. Move the caret/cursor after first digit and add a decimal point
5. Verify that the number changes to 1.23
6. Remove the decimal point and place it after the second digit
7. Verify that the number updates to 12.3

[mallenexpensify]

Contributor+: @thesahindia paid $250 via Upwork

Test case, thanks @thesahindia

• https://github.com/Expensify/Expensify/issues/447172

[garrettmknight]

$250 approved for @thesahindia

[garrettmknight]

Note that this wasn't paid via upwork on this job: https://www.upwork.com/ab/applicants/1846593217215177350/hired