Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Violations - Missing tag instead of Review required shown on expense preview if depende #47154

Closed
2 of 6 tasks
IuliiaHerets opened this issue Aug 9, 2024 · 5 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.18.4
Reproducible in staging?: Y
Reproducible in production?: Y
An issue was found when executing this PR #44995
Issue reported by: Applause Internal Team

Action Performed:

Precondition: user created a workspace, enabled the "Members must tag all expenses" and "Use multiple level of tags" toggles, and added Dependent tags in OD

  1. Go to https://staging.new.expensify.com/ and log in
  2. Click on FAB and submit a manual expense without selecting tags to a workspace with dependent tags enabled
  3. Submit another manual expense without selecting tags
  4. Navigate to the workspace chat
  5. Open the expense report

Expected Result:

"Review required" is displayed on the expense preview

Actual Result:

"Missing tag" is displayed on the expense preview

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6566155_1723159185501.review_required.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 9, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-control

@IuliiaHerets
Copy link
Author

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@jliexpensify
Copy link
Contributor

Hi @getusha - could you confirm if this is connected to @ShridharGoel's PR here? #44995

@cead22
Copy link
Contributor

cead22 commented Aug 12, 2024

I don't think the expected results here are right, so closing. @IuliiaHerets in the future please alwats include the email you used, and the policyID and reportIDs used/created so we can easily search for logs

@cead22 cead22 closed this as completed Aug 12, 2024
@cead22 cead22 self-assigned this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants