Avatar - Invalid avatar format error does not disappear after switching account

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in as a copilot.
3. Go to Account settings > Profile.
4. Upload a large image that will trigger error.
5. Click on the account switcher.
6. Select another account.

Expected Result:

The invalid avatar format error will disappear after switching account.

Actual Result:

The invalid avatar format error does not disappear after switching account.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6585962_1724889972466.20240829_080258.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invalid avatar format error does not disappear after switching account

What is the root cause of that problem?

We are only reseting error message on blur here

App/src/components/AvatarWithImagePicker.tsx

Lines 187 to 194 in 8c69c58

	useEffect(() => {
	if (isFocused) {
	return;
	}
	// Reset the error if the component is no longer focused.
	setError(null, {});
	}, [isFocused]);

And when the user changes current user (currentUserPersonalDetails) we don't reset error message

App/src/pages/settings/Profile/ProfilePage.tsx

Line 79 in 8c69c58

const avatarURL = currentUserPersonalDetails?.avatar ?? '';

App/src/pages/settings/Profile/ProfilePage.tsx

Lines 158 to 160 in 8c69c58

	<AvatarWithImagePicker
	isUsingDefaultAvatar={UserUtils.isDefaultAvatar(currentUserPersonalDetails?.avatar ?? '')}
	source={avatarURL}

What changes do you think we should make in order to solve the problem?

We should also reset error message when source (currentUserPersonalDetails?.avatar) for Avatar component changes.

 useEffect(() => {
        setError(null, {});
    }, [source]);

What alternative solutions did you explore? (Optional)

[puneetlath]

demoting since copilot is under beta cc @rushatgabhane

[madmax330]

@puneetlath @rushatgabhane should I make this external? Or is this part of a project?

[puneetlath]

It looks like it's part of the copilot project that is being worked on in #wave-control. I'm not sure who his working on that, but you should be able to ask there.

[rushatgabhane]

@puneetlath please assign it to me there is s mega PR on the way

[VictoriaExpensify]

Hey @puneetlath - is this a deploy blocker? Just trying to figure out what actions I need to take here.

[puneetlath]

No, I think copilot is still under beta, so not a blocker.

[melvin-bot]

This issue has not been updated in over 15 days. @madmax330, @rushatgabhane, @VictoriaExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[rushatgabhane]

we can close this. all patched up

[melvin-bot]

@madmax330, @rushatgabhane, @VictoriaExpensify, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.