Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-17] Rare build failures during apk assembling #49924

Closed
1 of 6 tasks
kirillzyusko opened this issue Sep 30, 2024 · 9 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@kirillzyusko
Copy link
Contributor

kirillzyusko commented Sep 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.40-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): N
Logs: https://github.com/Expensify/App/actions/runs/11034638063
Expensify/Expensify Issue URL:
Issue reported by: @hannojg spotted it
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1728029657508579

Action Performed:

  • merge code to main
  • automatic e2e build action will be triggered

Expected Result:

  • build action should be always stable

Actual Result:

  • sometimes action may randomly fail

Workaround:

Re-trigger pipeline manually.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @anmurali
@kirillzyusko kirillzyusko added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Sep 30, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 30, 2024
@kirillzyusko
Copy link
Contributor Author

I think the bug can be assigned on me as well, because I already prepared a fix for that 👀

Copy link

melvin-bot bot commented Oct 1, 2024

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@arosiclair
Copy link
Contributor

@kirillzyusko we don't have access to that margelo slack conversation. Can you start a conversation about this in one of our slack channels? I'm not sure if this is the right approach but somebody else might know better.

@kirillzyusko
Copy link
Contributor Author

@arosiclair I updated a link 🙌

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 10, 2024
@melvin-bot melvin-bot bot changed the title Rare build failures during apk assembling [HOLD for payment 2024-10-17] Rare build failures during apk assembling Oct 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 10, 2024
Copy link

melvin-bot bot commented Oct 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 10, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@arosiclair] The PR that introduced the bug has been identified. Link to the PR:
  • [@arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@arosiclair] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@kirillzyusko] Determine if we should create a regression test for this bug.
  • [@kirillzyusko] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@arosiclair
Copy link
Contributor

No C+ review and changes are from Margelo so we can just close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants